Publish1 patches

[PULL 00/12] Publish1 patches

Posted by Helge Deller 1 year, 7 months ago

The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51:

  Update version for v7.1.0 release (2022-08-30 09:40:11 -0700)

are available in the Git repository at:

  https://github.com/hdeller/qemu-hppa.git tags/publish1-pull-request

for you to fetch changes up to 7f8674a61a908592bb4e8e698f5bef84d0eeb8cc:

  linux-user: Add parameters of getrandom() syscall for strace (2022-09-18 21:35:27 +0200)

----------------------------------------------------------------
linux-user: Add more syscalls, enhance tracing & logging enhancements

Here is a bunch of patches for linux-user.

Most of them add missing syscalls and enhance the tracing/logging.
Some of the patches are target-hppa specific.
I've tested those on productive hppa debian buildd servers (running qemu-user).

Thanks!
Helge

Changes to v2:
- Fix build of close_range() and pidfd_*() patches on older Linux
  distributions (noticed by Stefan Hajnoczi)

Changes to v1:
- Dropped the faccessat2() syscall patch in favour of Richard's patch
- Various changes to the "missing signals in strace output" patch based on
  Richard's feedback, e.g. static arrays, fixed usage of _NSIG, fix build when
  TARGET_SIGIOT does not exist
- Use FUTEX_CMD_MASK in "Show timespec on strace for futex" patch
  unconditionally and turn into a switch statement - as suggested by Richard

----------------------------------------------------------------

Helge Deller (12):
  linux-user: Add missing signals in strace output
  linux-user: Add missing clock_gettime64() syscall strace
  linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd()
    syscalls
  linux-user: Log failing executable in EXCP_DUMP()
  linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info
  linux-user/hppa: Dump IIR on register dump
  linux-user: Fix strace of chmod() if mode == 0
  linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch
  linux-user: Add strace for clock_nanosleep()
  linux-user: Show timespec on strace for futex()
  linux-user: Add close_range() syscall
  linux-user: Add parameters of getrandom() syscall for strace

 linux-user/cpu_loop-common.h |   2 +
 linux-user/hppa/cpu_loop.c   |   6 +-
 linux-user/mmap.c            |   4 +
 linux-user/signal-common.h   |  46 ++++++++++++
 linux-user/signal.c          |  37 +--------
 linux-user/strace.c          | 142 ++++++++++++++++++++++++++++++-----
 linux-user/strace.list       |  21 +++++-
 linux-user/syscall.c         |  50 ++++++++++++
 target/hppa/helper.c         |   6 +-
 9 files changed, 255 insertions(+), 59 deletions(-)

--
2.37.3

Re: [PULL 00/12] Publish1 patches

Posted by Peter Maydell 1 year, 7 months ago

On Wed, 21 Sept 2022 at 00:00, Helge Deller <deller@gmx.de> wrote:
>
> The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51:
>
>   Update version for v7.1.0 release (2022-08-30 09:40:11 -0700)
>
> are available in the Git repository at:
>
>   https://github.com/hdeller/qemu-hppa.git tags/publish1-pull-request
>
> for you to fetch changes up to 7f8674a61a908592bb4e8e698f5bef84d0eeb8cc:
>
>   linux-user: Add parameters of getrandom() syscall for strace (2022-09-18 21:35:27 +0200)
>
> ----------------------------------------------------------------
> linux-user: Add more syscalls, enhance tracing & logging enhancements
>
> Here is a bunch of patches for linux-user.
>
> Most of them add missing syscalls and enhance the tracing/logging.
> Some of the patches are target-hppa specific.
> I've tested those on productive hppa debian buildd servers (running qemu-user).

Maybe I've missed some context in previous mailing list threads,
but I think overall it would be better for linux-user patches to
go through the linux-user tree; most of these don't seem hppa
specific.

thanks
-- PMM

Re: [PULL 00/12] Publish1 patches

Posted by Laurent Vivier 1 year, 7 months ago

Le 22/09/2022 à 11:37, Peter Maydell a écrit :
> On Wed, 21 Sept 2022 at 00:00, Helge Deller <deller@gmx.de> wrote:
>>
>> The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51:
>>
>>    Update version for v7.1.0 release (2022-08-30 09:40:11 -0700)
>>
>> are available in the Git repository at:
>>
>>    https://github.com/hdeller/qemu-hppa.git tags/publish1-pull-request
>>
>> for you to fetch changes up to 7f8674a61a908592bb4e8e698f5bef84d0eeb8cc:
>>
>>    linux-user: Add parameters of getrandom() syscall for strace (2022-09-18 21:35:27 +0200)
>>
>> ----------------------------------------------------------------
>> linux-user: Add more syscalls, enhance tracing & logging enhancements
>>
>> Here is a bunch of patches for linux-user.
>>
>> Most of them add missing syscalls and enhance the tracing/logging.
>> Some of the patches are target-hppa specific.
>> I've tested those on productive hppa debian buildd servers (running qemu-user).
> 
> Maybe I've missed some context in previous mailing list threads,
> but I think overall it would be better for linux-user patches to
> go through the linux-user tree; most of these don't seem hppa
> specific.

I'm sorry Peter, I think it's my fault, I didn't answer to people email [1] so they try to find 
another way to have their work merged.

I'm going to have a look to Helge series.

Thanks,
Laurent
[1] send me a private email if you want your email not filtered by my email client.

Re: [PULL 00/12] Publish1 patches

Posted by Philippe Mathieu-Daudé via 1 year, 7 months ago

Hi Helge,

On 20/9/22 19:31, Helge Deller wrote:
> The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51:
> 
>    Update version for v7.1.0 release (2022-08-30 09:40:11 -0700)
> 
> are available in the Git repository at:
> 
>    https://github.com/hdeller/qemu-hppa.git tags/publish1-pull-request
> 
> for you to fetch changes up to 7f8674a61a908592bb4e8e698f5bef84d0eeb8cc:
> 
>    linux-user: Add parameters of getrandom() syscall for strace (2022-09-18 21:35:27 +0200)
> 
> ----------------------------------------------------------------
> linux-user: Add more syscalls, enhance tracing & logging enhancements
> 
> Here is a bunch of patches for linux-user.
> 
> Most of them add missing syscalls and enhance the tracing/logging.
> Some of the patches are target-hppa specific.
> I've tested those on productive hppa debian buildd servers (running qemu-user).
> 
> Thanks!
> Helge
> 
> Changes to v2:
> - Fix build of close_range() and pidfd_*() patches on older Linux
>    distributions (noticed by Stefan Hajnoczi)
> 
> Changes to v1:
> - Dropped the faccessat2() syscall patch in favour of Richard's patch
> - Various changes to the "missing signals in strace output" patch based on
>    Richard's feedback, e.g. static arrays, fixed usage of _NSIG, fix build when
>    TARGET_SIGIOT does not exist
> - Use FUTEX_CMD_MASK in "Show timespec on strace for futex" patch
>    unconditionally and turn into a switch statement - as suggested by Richard
> 
> ----------------------------------------------------------------
> 
> Helge Deller (12):
>    linux-user: Add missing signals in strace output
>    linux-user: Add missing clock_gettime64() syscall strace
>    linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd()
>      syscalls
>    linux-user: Log failing executable in EXCP_DUMP()
>    linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info
>    linux-user/hppa: Dump IIR on register dump
>    linux-user: Fix strace of chmod() if mode == 0
>    linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch
>    linux-user: Add strace for clock_nanosleep()
>    linux-user: Show timespec on strace for futex()
>    linux-user: Add close_range() syscall
>    linux-user: Add parameters of getrandom() syscall for strace

It seems you missed my review comments:

- 
https://lore.kernel.org/qemu-devel/569161db-c8cf-9ae5-9ae6-161de7f22335@amsat.org/
- 
https://lore.kernel.org/qemu-devel/d1668b24-9c04-0e54-2a82-7174f0d46fc1@amsat.org/
- 
https://lore.kernel.org/qemu-devel/e8bfd1ba-cec7-7c29-9319-eb013c14a237@amsat.org/#t
- 
https://lore.kernel.org/qemu-devel/02090880-0db6-0a6b-60b0-b3313566b962@amsat.org/