[v3] linux-user: Add more syscalls, enhance tracing & logging enhancements

[PATCH v3 12/12] linux-user: Add parameters of getrandom() syscall for strace

Posted by Helge Deller 3 years, 4 months ago

Signed-off-by: Helge Deller <deller@gmx.de>
---
 linux-user/strace.list | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/strace.list b/linux-user/strace.list
index ad9ef94689..97d8ccadac 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -355,7 +355,7 @@
 { TARGET_NR_getpriority, "getpriority", "%s(%#x,%#x)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_getrandom
-{ TARGET_NR_getrandom, "getrandom", NULL, NULL, NULL },
+{ TARGET_NR_getrandom, "getrandom", "%s(%p,%u,%d)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_getresgid
 { TARGET_NR_getresgid, "getresgid" , NULL, NULL, NULL },
--
2.37.3

Re: [PATCH v3 12/12] linux-user: Add parameters of getrandom() syscall for strace

Posted by Philippe Mathieu-Daudé via 3 years, 4 months ago

On 18/9/22 21:45, Helge Deller wrote:
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>   linux-user/strace.list | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index ad9ef94689..97d8ccadac 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -355,7 +355,7 @@
>   { TARGET_NR_getpriority, "getpriority", "%s(%#x,%#x)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_getrandom
> -{ TARGET_NR_getrandom, "getrandom", NULL, NULL, NULL },
> +{ TARGET_NR_getrandom, "getrandom", "%s(%p,%u,%d)", NULL, NULL },

The last argument is unsigned.

Conditional to using "%s(%p,%u,%u)":
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>   #endif
>   #ifdef TARGET_NR_getresgid
>   { TARGET_NR_getresgid, "getresgid" , NULL, NULL, NULL },
> --
> 2.37.3
> 
>