[PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment

Lucas Mateus Castro(alqotel) posted 4 patches 3 years, 4 months ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>
There is a newer version of this series
[PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment
Posted by Lucas Mateus Castro(alqotel) 3 years, 4 months ago
From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>

ninja-build is missing from the RHEL environment, so a system prepared
with that script would still fail to compile QEMU.
Tested on a Fedora 36

Signed-off-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
---
 scripts/ci/setup/build-environment.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml
index 232525b91d..6df3e61d94 100644
--- a/scripts/ci/setup/build-environment.yml
+++ b/scripts/ci/setup/build-environment.yml
@@ -150,6 +150,7 @@
           - libepoxy-devel
           - libgcrypt-devel
           - lzo-devel
+          - ninja-build
           - make
           - mesa-libEGL-devel
           - nettle-devel
-- 
2.31.1
Re: [PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment
Posted by Thomas Huth 3 years, 4 months ago
On 14/09/2022 13.41, Lucas Mateus Castro(alqotel) wrote:
> From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>
> 
> ninja-build is missing from the RHEL environment, so a system prepared
> with that script would still fail to compile QEMU.
> Tested on a Fedora 36
> 
> Signed-off-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
> ---
>   scripts/ci/setup/build-environment.yml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml
> index 232525b91d..6df3e61d94 100644
> --- a/scripts/ci/setup/build-environment.yml
> +++ b/scripts/ci/setup/build-environment.yml
> @@ -150,6 +150,7 @@
>             - libepoxy-devel
>             - libgcrypt-devel
>             - lzo-devel
> +          - ninja-build
>             - make
>             - mesa-libEGL-devel
>             - nettle-devel

Looks like the list used to be sorted alphabetically, so maybe you should 
sort it in some lines later?

And I wonder why this hasn't been noticed before ... Cleber, was this in use 
after all?

  Thomas
Re: [PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment
Posted by Lucas Mateus Martins Araujo e Castro 3 years, 4 months ago

On 15/09/2022 12:54, Thomas Huth wrote:

> On 14/09/2022 13.41, Lucas Mateus Castro(alqotel) wrote:
>> From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>
>>
>> ninja-build is missing from the RHEL environment, so a system prepared
>> with that script would still fail to compile QEMU.
>> Tested on a Fedora 36
>>
>> Signed-off-by: Lucas Mateus Castro (alqotel) 
>> <lucas.araujo@eldorado.org.br>
>> ---
>>   scripts/ci/setup/build-environment.yml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/ci/setup/build-environment.yml 
>> b/scripts/ci/setup/build-environment.yml
>> index 232525b91d..6df3e61d94 100644
>> --- a/scripts/ci/setup/build-environment.yml
>> +++ b/scripts/ci/setup/build-environment.yml
>> @@ -150,6 +150,7 @@
>>             - libepoxy-devel
>>             - libgcrypt-devel
>>             - lzo-devel
>> +          - ninja-build
>>             - make
>>             - mesa-libEGL-devel
>>             - nettle-devel
> 
> Looks like the list used to be sorted alphabetically, so maybe you should
> sort it in some lines later?
D'oh, I'll send a v3 fixing that.
> 
> And I wonder why this hasn't been noticed before ... Cleber, was this in 
> use
> after all?
> 
>   Thomas
> 

-- 
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO
<https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Analista de Software Junior
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>