[v8] qapi: net: add unix socket type support to netdev backend

[PATCH v8 06/14] net: stream: Don't ignore EINVAL on netdev socket connection

Posted by Laurent Vivier 3 years, 4 months ago

From: Stefano Brivio <sbrivio@redhat.com>

Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 net/stream.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/stream.c b/net/stream.c
index 0851e90becca..e8afbaca50b6 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -363,8 +363,7 @@ static int net_stream_client_init(NetClientState *peer,
                 if (errno == EINTR || errno == EWOULDBLOCK) {
                     /* continue */
                 } else if (errno == EINPROGRESS ||
-                           errno == EALREADY ||
-                           errno == EINVAL) {
+                           errno == EALREADY) {
                     break;
                 } else {
                     error_setg_errno(errp, errno, "can't connect socket");
-- 
2.37.3

Re: [PATCH v8 06/14] net: stream: Don't ignore EINVAL on netdev socket connection

Posted by David Gibson 3 years, 4 months ago

On Tue, Sep 13, 2022 at 08:39:52AM +0200, Laurent Vivier wrote:
> From: Stefano Brivio <sbrivio@redhat.com>
> 
> Other errors are treated as failure by net_stream_client_init(),
> but if connect() returns EINVAL, we'll fail silently. Remove the
> related exception.

Is this also a bug in net_socket_connect_init()?  Is there an
equivalent bug in dgram.c?

> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> [lvivier: applied to net/stream.c]
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  net/stream.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/stream.c b/net/stream.c
> index 0851e90becca..e8afbaca50b6 100644
> --- a/net/stream.c
> +++ b/net/stream.c
> @@ -363,8 +363,7 @@ static int net_stream_client_init(NetClientState *peer,
>                  if (errno == EINTR || errno == EWOULDBLOCK) {
>                      /* continue */
>                  } else if (errno == EINPROGRESS ||
> -                           errno == EALREADY ||
> -                           errno == EINVAL) {
> +                           errno == EALREADY) {
>                      break;
>                  } else {
>                      error_setg_errno(errp, errno, "can't connect socket");

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH v8 06/14] net: stream: Don't ignore EINVAL on netdev socket connection

Posted by Laurent Vivier 3 years, 4 months ago

On 9/14/22 07:05, David Gibson wrote:
> On Tue, Sep 13, 2022 at 08:39:52AM +0200, Laurent Vivier wrote:
>> From: Stefano Brivio <sbrivio@redhat.com>
>>
>> Other errors are treated as failure by net_stream_client_init(),
>> but if connect() returns EINVAL, we'll fail silently. Remove the
>> related exception.
> 
> Is this also a bug in net_socket_connect_init()?  Is there an
> equivalent bug in dgram.c?

Yes, the bug has been found by Stefano in socket.c, I'm adding his patch to the series.
There is no equivalent bug in dgram.c

Thanks,
Laurent