[PATCH v3 19/24] disas/nanomips: Remove function overloading

Milica Lazarevic posted 24 patches 3 years, 4 months ago
Maintainers: Stefan Pejic <stefan.pejic@syrmia.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>
[PATCH v3 19/24] disas/nanomips: Remove function overloading
Posted by Milica Lazarevic 3 years, 4 months ago
Disassemble function that calls the other variant of it is deleted.
Where it is called, now we're directly calling the other implementation.

Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com>
---
 disas/nanomips.cpp | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
index 52b3708f75..132cf89f6c 100644
--- a/disas/nanomips.cpp
+++ b/disas/nanomips.cpp
@@ -21917,11 +21917,6 @@ static const Pool MAJOR[2] = {
        0x0                 },        /* P16 */
 };
 
-static int Disassemble(const uint16 *data, char **dis,
-                     TABLE_ENTRY_TYPE & type, Dis_info *info)
-{
-    return Disassemble(data, dis, type, MAJOR, 2, info);
-}
 
 static int nanomips_dis(char **buf,
                  Dis_info *info,
@@ -21932,7 +21927,7 @@ static int nanomips_dis(char **buf,
     uint16 bits[3] = {one, two, three};
 
     TABLE_ENTRY_TYPE type;
-    int size = Disassemble(bits, buf, type, info);
+    int size = Disassemble(bits, buf, type, MAJOR, 2, info);
     return size;
 }
 
-- 
2.25.1
Re: [PATCH v3 19/24] disas/nanomips: Remove function overloading
Posted by Richard Henderson 3 years, 4 months ago
On 9/12/22 13:26, Milica Lazarevic wrote:
> Disassemble function that calls the other variant of it is deleted.
> Where it is called, now we're directly calling the other implementation.
> 
> Signed-off-by: Milica Lazarevic<milica.lazarevic@syrmia.com>
> ---
>   disas/nanomips.cpp | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~