[v1] Introduce Xilinx Versal CANFD

[QEMU][PATCH 0/5] Introduce Xilinx Versal CANFD

Posted by Vikram Garhwal 3 years, 5 months ago

Hi,
This patch implements CANFD controller for xlnx-versal-virt machine. There are
two controllers CANFD0@0xFF06_0000 and CANFD1@0xFF07_0000 are connected to the
machine.

Also, added basic qtests for data exchange between both the controllers in
various supported configs.

Regards,
Vikram

Vikram Garhwal (5):
  MAINTAINERS: Update maintainer's email for Xilinx CAN
  hw/net/can: Introduce Xilinx Versal CANFD controller
  xlnx-zynqmp: Connect Xilinx VERSAL CANFD controllers
  tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller
  MAINTAINERS: Include canfd tests under Xilinx CAN

 MAINTAINERS                        |    6 +-
 hw/arm/xlnx-versal-virt.c          |   45 +
 hw/arm/xlnx-versal.c               |   37 +
 hw/net/can/meson.build             |    1 +
 hw/net/can/trace-events            |    7 +
 hw/net/can/xlnx-versal-canfd.c     | 2157 ++++++++++++++++++++++++++++
 include/hw/arm/xlnx-versal.h       |   12 +
 include/hw/net/xlnx-versal-canfd.h |   92 ++
 tests/qtest/meson.build            |    1 +
 tests/qtest/xlnx-canfd-test.c      |  421 ++++++
 10 files changed, 2776 insertions(+), 3 deletions(-)
 create mode 100644 hw/net/can/xlnx-versal-canfd.c
 create mode 100644 include/hw/net/xlnx-versal-canfd.h
 create mode 100644 tests/qtest/xlnx-canfd-test.c

-- 
2.17.1

Re: [QEMU][PATCH 0/5] Introduce Xilinx Versal CANFD

Posted by Peter Maydell 3 years, 4 months ago

On Sat, 10 Sept 2022 at 09:15, Vikram Garhwal <vikram.garhwal@amd.com> wrote:
>
> Hi,
> This patch implements CANFD controller for xlnx-versal-virt machine. There are
> two controllers CANFD0@0xFF06_0000 and CANFD1@0xFF07_0000 are connected to the
> machine.
>
> Also, added basic qtests for data exchange between both the controllers in
> various supported configs.
>
> Regards,
> Vikram
>
> Vikram Garhwal (5):
>   MAINTAINERS: Update maintainer's email for Xilinx CAN
>   hw/net/can: Introduce Xilinx Versal CANFD controller
>   xlnx-zynqmp: Connect Xilinx VERSAL CANFD controllers
>   tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller
>   MAINTAINERS: Include canfd tests under Xilinx CAN

Hi -- something odd seems to have happened with the cover letter for this
series: the patches haven't ended up as followups to the cover letter.
You can see this in the lore archive where the cover letter ends up
here on its own:
https://lore.kernel.org/qemu-devel/20220910061209.2559-1-vikram.garhwal@amd.com/
but the actual patches are here, with 2,3,4,5 showing up as replies to 1:
https://lore.kernel.org/qemu-devel/20220910061252.2614-1-vikram.garhwal@amd.com/
This means that patchew couldn't find the patches:
https://patchew.org/QEMU/20220910061209.2559-1-vikram.garhwal@amd.com/

If you could look at what went wrong in your config for next time it
will make the tooling happier.

thanks
-- PMM

Re: [QEMU][PATCH 0/5] Introduce Xilinx Versal CANFD

Posted by Vikram Garhwal 3 years, 4 months ago

Hi Peter,

Thanks for pointing this. Looks like my configs are outdated. Will take 
care of this for v2.

Regards,

Vikram

On 9/22/22 7:20 AM, Peter Maydell wrote:
> On Sat, 10 Sept 2022 at 09:15, Vikram Garhwal <vikram.garhwal@amd.com> wrote:
>> Hi,
>> This patch implements CANFD controller for xlnx-versal-virt machine. There are
>> two controllers CANFD0@0xFF06_0000 and CANFD1@0xFF07_0000 are connected to the
>> machine.
>>
>> Also, added basic qtests for data exchange between both the controllers in
>> various supported configs.
>>
>> Regards,
>> Vikram
>>
>> Vikram Garhwal (5):
>>    MAINTAINERS: Update maintainer's email for Xilinx CAN
>>    hw/net/can: Introduce Xilinx Versal CANFD controller
>>    xlnx-zynqmp: Connect Xilinx VERSAL CANFD controllers
>>    tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller
>>    MAINTAINERS: Include canfd tests under Xilinx CAN
> Hi -- something odd seems to have happened with the cover letter for this
> series: the patches haven't ended up as followups to the cover letter.
> You can see this in the lore archive where the cover letter ends up
> here on its own:
> https://lore.kernel.org/qemu-devel/20220910061209.2559-1-vikram.garhwal@amd.com/
> but the actual patches are here, with 2,3,4,5 showing up as replies to 1:
> https://lore.kernel.org/qemu-devel/20220910061252.2614-1-vikram.garhwal@amd.com/
> This means that patchew couldn't find the patches:
> https://patchew.org/QEMU/20220910061209.2559-1-vikram.garhwal@amd.com/
>
> If you could look at what went wrong in your config for next time it
> will make the tooling happier.
>
> thanks
> -- PMM