[v7] QMP/HMP: introduce 'dumpdtb'

[PATCH v7 08/14] hw/ppc: set machine->fdt in pegasos2_machine_reset()

Posted by Daniel Henrique Barboza 3 years, 5 months ago

We'll introduce a QMP/HMP command that requires machine->fdt to be set
properly.

Cc: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-ppc@nongnu.org
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 hw/ppc/pegasos2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index 61f4263953..ecf682b148 100644
--- a/hw/ppc/pegasos2.c
+++ b/hw/ppc/pegasos2.c
@@ -331,6 +331,10 @@ static void pegasos2_machine_reset(MachineState *machine)
 
     vof_build_dt(fdt, pm->vof);
     vof_client_open_store(fdt, pm->vof, "/chosen", "stdout", "/failsafe");
+
+    /* Set machine->fdt for 'dumpdtb' QMP/HMP command */
+    machine->fdt = fdt;
+
     pm->cpu->vhyp = PPC_VIRTUAL_HYPERVISOR(machine);
 }
 
-- 
2.37.2

Re: [PATCH v7 08/14] hw/ppc: set machine->fdt in pegasos2_machine_reset()

Posted by BALATON Zoltan 3 years, 5 months ago

On Thu, 8 Sep 2022, Daniel Henrique Barboza wrote:
> We'll introduce a QMP/HMP command that requires machine->fdt to be set
> properly.
>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
> Cc: qemu-ppc@nongnu.org
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

> ---
> hw/ppc/pegasos2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
> index 61f4263953..ecf682b148 100644
> --- a/hw/ppc/pegasos2.c
> +++ b/hw/ppc/pegasos2.c
> @@ -331,6 +331,10 @@ static void pegasos2_machine_reset(MachineState *machine)
>
>     vof_build_dt(fdt, pm->vof);
>     vof_client_open_store(fdt, pm->vof, "/chosen", "stdout", "/failsafe");
> +
> +    /* Set machine->fdt for 'dumpdtb' QMP/HMP command */
> +    machine->fdt = fdt;
> +
>     pm->cpu->vhyp = PPC_VIRTUAL_HYPERVISOR(machine);
> }
>
>

Re: [PATCH v7 08/14] hw/ppc: set machine->fdt in pegasos2_machine_reset()

Posted by Philippe Mathieu-Daudé via 3 years, 4 months ago

On 8/9/22 21:58, BALATON Zoltan wrote:
> On Thu, 8 Sep 2022, Daniel Henrique Barboza wrote:
>> We'll introduce a QMP/HMP command that requires machine->fdt to be set
>> properly.
>>
>> Cc: BALATON Zoltan <balaton@eik.bme.hu>
>> Cc: qemu-ppc@nongnu.org
>> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> 
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> 
>> ---
>> hw/ppc/pegasos2.c | 4 ++++
>> 1 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>