[v1] smbios: sanitize type from external type before checking have_fields_bitmap

[PATCH] smbios: sanitize type from external type before checking have_fields_bitmap

Paolo Bonzini posted 1 patch 1 year, 7 months ago

Diff against v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220905103606.27978-1-pbonzini@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>

There is a newer version of this series

hw/smbios/smbios.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] smbios: sanitize type from external type before checking have_fields_bitmap

Posted by Paolo Bonzini 1 year, 7 months ago

test_bit uses header->type as an offset; if the file incorrectly specifies a
type greater than 127, smbios_entry_add will read garbage.

To fix this, just pass the smbios data through, assuming the user knows what
to do.  Reported by Coverity as CID 1487255.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/smbios/smbios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index 60349ee402..485fa15202 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -1205,7 +1205,8 @@ void smbios_entry_add(QemuOpts *opts, Error **errp)
             return;
         }
 
-        if (test_bit(header->type, have_fields_bitmap)) {
+        if (header->type <= SMBIOS_MAX_TYPE &&
+            test_bit(header->type, have_fields_bitmap)) {
             error_setg(errp,
                        "can't load type %d struct, fields already specified!",
                        header->type);
-- 
2.37.2

Re: [PATCH] smbios: sanitize type from external type before checking have_fields_bitmap

Posted by Philippe Mathieu-Daudé via 1 year, 7 months ago

On 5/9/22 12:36, Paolo Bonzini wrote:
> test_bit uses header->type as an offset; if the file incorrectly specifies a
> type greater than 127, smbios_entry_add will read garbage.
> 
> To fix this, just pass the smbios data through, assuming the user knows what
> to do.  Reported by Coverity as CID 1487255.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/smbios/smbios.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
> index 60349ee402..485fa15202 100644
> --- a/hw/smbios/smbios.c
> +++ b/hw/smbios/smbios.c
> @@ -1205,7 +1205,8 @@ void smbios_entry_add(QemuOpts *opts, Error **errp)
>               return;
>           }
>   
> -        if (test_bit(header->type, have_fields_bitmap)) {
> +        if (header->type <= SMBIOS_MAX_TYPE &&
> +            test_bit(header->type, have_fields_bitmap)) {
>               error_setg(errp,
>                          "can't load type %d struct, fields already specified!",
>                          header->type);

Completing the diff:

             return;
         }
         set_bit(header->type, have_binfile_bitmap);

Same problem  here ^^^

It seems safer to check header->type range before load_image_size().