coverity: put NUBus under m68k component

[PATCH] coverity: put NUBus under m68k component

Posted by Paolo Bonzini 1 year, 7 months ago

It is only used by the Q800 emulation, so put it under that architecture.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/coverity-scan/COMPONENTS.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
index fc1608932e..0e6ab4936e 100644
--- a/scripts/coverity-scan/COMPONENTS.md
+++ b/scripts/coverity-scan/COMPONENTS.md
@@ -22,7 +22,7 @@ i386
   ~ (/qemu)?((/include)?/hw/i386/.*|/target/i386/.*|/hw/intc/[^/]*apic[^/]*\.c)
 
 m68k
-  ~ (/qemu)?((/include)?/hw/m68k/.*|/target/m68k/.*|(/include)?/hw(/.*)?/mcf.*)
+  ~ (/qemu)?((/include)?/hw/m68k/.*|/target/m68k/.*|(/include)?/hw(/.*)?/mcf.*|(/include)?/hw/nubus/.*)
 
 microblaze
   ~ (/qemu)?((/include)?/hw/microblaze/.*|/target/microblaze/.*)
-- 
2.37.2

Re: [PATCH] coverity: put NUBus under m68k component

Posted by Philippe Mathieu-Daudé via 1 year, 7 months ago

On 5/9/22 12:26, Paolo Bonzini wrote:
> It is only used by the Q800 emulation, so put it under that architecture.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   scripts/coverity-scan/COMPONENTS.md | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
> index fc1608932e..0e6ab4936e 100644
> --- a/scripts/coverity-scan/COMPONENTS.md
> +++ b/scripts/coverity-scan/COMPONENTS.md
> @@ -22,7 +22,7 @@ i386
>     ~ (/qemu)?((/include)?/hw/i386/.*|/target/i386/.*|/hw/intc/[^/]*apic[^/]*\.c)
>   
>   m68k
> -  ~ (/qemu)?((/include)?/hw/m68k/.*|/target/m68k/.*|(/include)?/hw(/.*)?/mcf.*)
> +  ~ (/qemu)?((/include)?/hw/m68k/.*|/target/m68k/.*|(/include)?/hw(/.*)?/mcf.*|(/include)?/hw/nubus/.*)
>   
>   microblaze
>     ~ (/qemu)?((/include)?/hw/microblaze/.*|/target/microblaze/.*)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] coverity: put NUBus under m68k component

Posted by Peter Maydell 1 year, 7 months ago

On Mon, 5 Sept 2022 at 12:07, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> It is only used by the Q800 emulation, so put it under that architecture.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/coverity-scan/COMPONENTS.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
> index fc1608932e..0e6ab4936e 100644
> --- a/scripts/coverity-scan/COMPONENTS.md
> +++ b/scripts/coverity-scan/COMPONENTS.md
> @@ -22,7 +22,7 @@ i386
>    ~ (/qemu)?((/include)?/hw/i386/.*|/target/i386/.*|/hw/intc/[^/]*apic[^/]*\.c)
>
>  m68k
> -  ~ (/qemu)?((/include)?/hw/m68k/.*|/target/m68k/.*|(/include)?/hw(/.*)?/mcf.*)
> +  ~ (/qemu)?((/include)?/hw/m68k/.*|/target/m68k/.*|(/include)?/hw(/.*)?/mcf.*|(/include)?/hw/nubus/.*)
>
>  microblaze
>    ~ (/qemu)?((/include)?/hw/microblaze/.*|/target/microblaze/.*)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

On the subject of coverity components:
 * we should drop the 'capstone' component now we've removed that submodule
 * https://scan.coverity.com/projects/qemu?tab=overview says the 'hvf'
   component has 0 lines in it, which suggests we got that regex wrong
   somehow, or there's an ordering issue and some higher-up component
   has already claimed all the files

thanks
-- PMM