[v1] Fix some problems with vvfat in R/W mode

[PATCH 2/2] vvfat: allow spaces in file names

Posted by Hervé Poussineau 3 years, 5 months ago

In R/W mode, files with spaces were never created on host side.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176
Fixes: c79e243ed67683d6d06692bd7040f7394da178b0
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 block/vvfat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index 35057a51c67..9d877028573 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -499,7 +499,7 @@ static bool valid_filename(const unsigned char *name)
               (c >= 'A' && c <= 'Z') ||
               (c >= 'a' && c <= 'z') ||
               c > 127 ||
-              strchr("$%'-_@~`!(){}^#&.+,;=[]", c) != NULL))
+              strchr(" $%'-_@~`!(){}^#&.+,;=[]", c) != NULL))
         {
             return false;
         }
-- 
2.36.2

Re: [PATCH 2/2] vvfat: allow spaces in file names

Posted by Kevin Wolf 3 years, 4 months ago

Am 03.09.2022 um 18:23 hat Hervé Poussineau geschrieben:
> In R/W mode, files with spaces were never created on host side.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176
> Fixes: c79e243ed67683d6d06692bd7040f7394da178b0
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Re: [PATCH 2/2] vvfat: allow spaces in file names

Posted by Philippe Mathieu-Daudé via 3 years, 5 months ago

On 3/9/22 18:23, Hervé Poussineau wrote:
> In R/W mode, files with spaces were never created on host side.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176
> Fixes: c79e243ed67683d6d06692bd7040f7394da178b0
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>   block/vvfat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 35057a51c67..9d877028573 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -499,7 +499,7 @@ static bool valid_filename(const unsigned char *name)
>                 (c >= 'A' && c <= 'Z') ||
>                 (c >= 'a' && c <= 'z') ||
>                 c > 127 ||
> -              strchr("$%'-_@~`!(){}^#&.+,;=[]", c) != NULL))
> +              strchr(" $%'-_@~`!(){}^#&.+,;=[]", c) != NULL))
>           {
>               return false;
>           }

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>