tests: Make expliction defaults for tests

[PATCH 2/8] qtest: Set "-net none" in qtest_init()

Posted by Juan Quintela 3 years, 5 months ago

This way, we don't have networking by default.  If test needs it,
configure it.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 tests/qtest/bios-tables-test.c | 2 +-
 tests/qtest/libqtest.c         | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 9c68f3658a..a0853744ae 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -725,7 +725,7 @@ static char *test_acpi_create_args(test_data *data, const char *params,
         }
     } else {
         args = g_strdup_printf("-machine %s %s -accel tcg "
-            "-net none %s "
+            "%s "
             "-drive id=hd0,if=none,file=%s,format=raw "
             "-device %s,drive=hd0 ",
              data->machine, data->tcg_only ? "" : "-accel kvm",
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 7c9fc07de4..ee84dbfc36 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -290,6 +290,7 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)
                               "-chardev socket,path=%s,id=char0 "
                               "-mon chardev=char0,mode=control "
                               "-display none "
+                              "-net none "
                               "%s"
                               " -accel qtest",
                               qemu_binary, tracearg, socket_path,
-- 
2.37.2

Re: [PATCH 2/8] qtest: Set "-net none" in qtest_init()

Posted by Philippe Mathieu-Daudé via 3 years, 5 months ago

On 2/9/22 18:51, Juan Quintela wrote:
> This way, we don't have networking by default.  If test needs it,
> configure it.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>   tests/qtest/bios-tables-test.c | 2 +-
>   tests/qtest/libqtest.c         | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>