[v1] Multiple ppc instructions fixes

[PATCH 02/19] target/ppc: Remove unused xer_* macros

Posted by Víctor Colombo 3 years, 5 months ago

The macros xer_ov, xer_ca, xer_ov32, and xer_ca32 are both unused and
hiding the usage of env. Remove them.

Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
---
 target/ppc/cpu.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index 985ff86f55..6481f48087 100644
--- a/target/ppc/cpu.h
+++ b/target/ppc/cpu.h
@@ -1506,10 +1506,6 @@ void ppc_compat_add_property(Object *obj, const char *name,
 #define XER_CMP  8
 #define XER_BC   0
 #define xer_so  (env->so)
-#define xer_ov  (env->ov)
-#define xer_ca  (env->ca)
-#define xer_ov32  (env->ov)
-#define xer_ca32  (env->ca)
 #define xer_cmp ((env->xer >> XER_CMP) & 0xFF)
 #define xer_bc  ((env->xer >> XER_BC)  & 0x7F)
 
-- 
2.25.1

Re: [PATCH 02/19] target/ppc: Remove unused xer_* macros

Posted by Daniel Henrique Barboza 3 years, 5 months ago


On 9/1/22 10:17, Víctor Colombo wrote:
> The macros xer_ov, xer_ca, xer_ov32, and xer_ca32 are both unused and
> hiding the usage of env. Remove them.
> 
> Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   target/ppc/cpu.h | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index 985ff86f55..6481f48087 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -1506,10 +1506,6 @@ void ppc_compat_add_property(Object *obj, const char *name,
>   #define XER_CMP  8
>   #define XER_BC   0
>   #define xer_so  (env->so)
> -#define xer_ov  (env->ov)
> -#define xer_ca  (env->ca)
> -#define xer_ov32  (env->ov)
> -#define xer_ca32  (env->ca)
>   #define xer_cmp ((env->xer >> XER_CMP) & 0xFF)
>   #define xer_bc  ((env->xer >> XER_BC)  & 0x7F)
>