qapi examples fixes and rfc for another generator

[PATCH v1 08/16] qapi: fix example of NIC_RX_FILTER_CHANGED event

Victor Toso posted 16 patches 3 years, 5 months ago

Download mbox

Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Yanan Wang <wangyanan55@huawei.com>, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Jiri Pirko <jiri@resnulli.us>, Gerd Hoffmann <kraxel@redhat.com>, Michael Roth <michael.roth@amd.com>

Expand all Fold all

[PATCH v1 08/16] qapi: fix example of NIC_RX_FILTER_CHANGED event

Posted by Victor Toso 3 years, 5 months ago

Example output has an extra ending curly bracket. Fix it.

Problem was noticed when trying to load the example into python's json
library.

Signed-off-by: Victor Toso <victortoso@redhat.com>
---
 qapi/net.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/net.json b/qapi/net.json
index 75ba2cb989..a8ad698e7d 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -756,7 +756,7 @@
 # <- { "event": "NIC_RX_FILTER_CHANGED",
 #      "data": { "name": "vnet0",
 #                "path": "/machine/peripheral/vnet0/virtio-backend" },
-#      "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
+#      "timestamp": { "seconds": 1368697518, "microseconds": 326866 }
 #    }
 #
 ##
-- 
2.37.2

Re: [PATCH v1 08/16] qapi: fix example of NIC_RX_FILTER_CHANGED event

Posted by Markus Armbruster 3 years, 5 months ago

Victor Toso <victortoso@redhat.com> writes:

> Example output has an extra ending curly bracket. Fix it.
>
> Problem was noticed when trying to load the example into python's json
> library.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  qapi/net.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/net.json b/qapi/net.json
> index 75ba2cb989..a8ad698e7d 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -756,7 +756,7 @@
>  # <- { "event": "NIC_RX_FILTER_CHANGED",
>  #      "data": { "name": "vnet0",
>  #                "path": "/machine/peripheral/vnet0/virtio-backend" },
> -#      "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
> +#      "timestamp": { "seconds": 1368697518, "microseconds": 326866 }
>  #    }
>  #
>  ##

Again, for local consistency:

diff --git a/qapi/net.json b/qapi/net.json
index 75ba2cb989..dd088c09c5 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -757,7 +757,6 @@
 #      "data": { "name": "vnet0",
 #                "path": "/machine/peripheral/vnet0/virtio-backend" },
 #      "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
-#    }
 #
 ##
 { 'event': 'NIC_RX_FILTER_CHANGED',