qapi examples fixes and rfc for another generator

[PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command

Victor Toso posted 16 patches 3 years, 5 months ago

Download mbox

Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Yanan Wang <wangyanan55@huawei.com>, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Jiri Pirko <jiri@resnulli.us>, Gerd Hoffmann <kraxel@redhat.com>, Michael Roth <michael.roth@amd.com>

Expand all Fold all

[PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command

Posted by Victor Toso 3 years, 5 months ago

Example output has an extra ',' delimiter and a foreign comment
format. Fix it.

Problem was noticed when trying to load the example into python's json
library.

Signed-off-by: Victor Toso <victortoso@redhat.com>
---
 qapi/rocker.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/qapi/rocker.json b/qapi/rocker.json
index b48e49a89b..6ae8689026 100644
--- a/qapi/rocker.json
+++ b/qapi/rocker.json
@@ -251,8 +251,7 @@
 #                   "cookie": 0,
 #                   "action": {"goto-tbl": 10},
 #                   "mask": {"in-pport": 4294901760}
-#                  },
-#                  {...more...},
+#                  }
 #    ]}
 #
 ##
-- 
2.37.2

Re: [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command

Posted by Markus Armbruster 3 years, 5 months ago

Victor Toso <victortoso@redhat.com> writes:

> Example output has an extra ',' delimiter and a foreign comment
> format. Fix it.
>
> Problem was noticed when trying to load the example into python's json
> library.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  qapi/rocker.json | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi/rocker.json b/qapi/rocker.json
> index b48e49a89b..6ae8689026 100644
> --- a/qapi/rocker.json
> +++ b/qapi/rocker.json
> @@ -251,8 +251,7 @@
>  #                   "cookie": 0,
>  #                   "action": {"goto-tbl": 10},
>  #                   "mask": {"in-pport": 4294901760}
> -#                  },
> -#                  {...more...},
> +#                  }
>  #    ]}
>  #
>  ##

Review of previous patch applies.