[PATCH v6 02/10] parallels: Fix high_off calculation in parallels_co_check()

Alexander Ivanov posted 10 patches 3 years, 5 months ago
Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, "Denis V. Lunev" <den@openvz.org>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
There is a newer version of this series
[PATCH v6 02/10] parallels: Fix high_off calculation in parallels_co_check()
Posted by Alexander Ivanov 3 years, 5 months ago
Don't let high_off be more than the file size even if we don't fix the image.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 block/parallels.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index 93bc2750ef..7e8cdbbc3a 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -460,12 +460,12 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
                     fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
             res->corruptions++;
             if (fix & BDRV_FIX_ERRORS) {
-                prev_off = 0;
                 s->bat_bitmap[i] = 0;
                 res->corruptions_fixed++;
                 flush_bat = true;
-                continue;
             }
+            prev_off = 0;
+            continue;
         }
 
         res->bfi.allocated_clusters++;
-- 
2.34.1
Re: [PATCH v6 02/10] parallels: Fix high_off calculation in parallels_co_check()
Posted by Denis V. Lunev 3 years, 5 months ago
On 25.08.2022 16:31, Alexander Ivanov wrote:
> Don't let high_off be more than the file size even if we don't fix the image.
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> ---
>   block/parallels.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 93bc2750ef..7e8cdbbc3a 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -460,12 +460,12 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
>                       fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
>               res->corruptions++;
>               if (fix & BDRV_FIX_ERRORS) {
> -                prev_off = 0;
>                   s->bat_bitmap[i] = 0;
>                   res->corruptions_fixed++;
>                   flush_bat = true;
> -                continue;
>               }
> +            prev_off = 0;
> +            continue;
>           }
>   
>           res->bfi.allocated_clusters++;
with string length fixes in the commit message (more that 74 chars)

Reviewed-by: Denis V. Lunev <den@openvz.org>