target/s390x: s390_probe_access fixes

[PATCH 0/2] target/s390x: s390_probe_access fixes

Richard Henderson posted 2 patches 1 year, 8 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220823213805.1970804-1-richard.henderson@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>

target/s390x/tcg/mem_helper.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH 0/2] target/s390x: s390_probe_access fixes

Posted by Richard Henderson 1 year, 8 months ago

First, as pointed out by David; second by inspection.

I really wish there were a better way to structure this,
but alas, I don't see any alternatives that aren't just
different but similar amounts of ugly.


r~


Richard Henderson (2):
  Revert "target/s390x: Use probe_access_flags in s390_probe_access"
  target/s390x: Align __excp_addr in s390_probe_access

 target/s390x/tcg/mem_helper.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] target/s390x: s390_probe_access fixes

Posted by David Hildenbrand 1 year, 8 months ago

On 23.08.22 23:38, Richard Henderson wrote:
> First, as pointed out by David; second by inspection.
> 
> I really wish there were a better way to structure this,
> but alas, I don't see any alternatives that aren't just
> different but similar amounts of ugly.
> 

The only feasible way would be having a arch-specific callback from
inside the probe code that would, similarly to tlb_fill code for !USER
store these values in the cpu environment -- then we could similarly
just look them up after the probe access.

-- 
Thanks,

David / dhildenb