meson: remove dead assignments

[PATCH] meson: remove dead assignments

Posted by Paolo Bonzini 3 years, 5 months ago

Found with "muon analyze".

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 plugins/meson.build           |  2 +-
 tests/fp/meson.build          |  2 +-
 tests/qapi-schema/meson.build | 24 ++++++++++++------------
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/plugins/meson.build b/plugins/meson.build
index fa12047327..752377c66d 100644
--- a/plugins/meson.build
+++ b/plugins/meson.build
@@ -2,7 +2,7 @@ plugin_ldflags = []
 # Modules need more symbols than just those in plugins/qemu-plugins.symbols
 if not enable_modules
   if targetos == 'darwin'
-    qemu_plugins_symbols_list = configure_file(
+    configure_file(
       input: files('qemu-plugins.symbols'),
       output: 'qemu-plugins-ld64.symbols',
       capture: true,
diff --git a/tests/fp/meson.build b/tests/fp/meson.build
index 2b4f00b916..6258e2bd7d 100644
--- a/tests/fp/meson.build
+++ b/tests/fp/meson.build
@@ -632,7 +632,7 @@ test('fp-test-mulAdd', fptest,
            ['f16_mulAdd', 'f32_mulAdd', 'f64_mulAdd', 'f128_mulAdd'],
      suite: ['softfloat-slow', 'softfloat-ops-slow', 'slow'], timeout: 90)
 
-fpbench = executable(
+executable(
   'fp-bench',
   ['fp-bench.c', '../../fpu/softfloat.c'],
   link_with: [libtestfloat, libsoftfloat],
diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build
index c18dd7d02f..406bc7255d 100644
--- a/tests/qapi-schema/meson.build
+++ b/tests/qapi-schema/meson.build
@@ -215,18 +215,18 @@ test('QAPI schema regression tests', python,
 
 diff = find_program('diff')
 
-qapi_doc = custom_target('QAPI doc',
-                         output: ['doc-good-qapi-commands.c', 'doc-good-qapi-commands.h',
-                                  'doc-good-qapi-emit-events.c', 'doc-good-qapi-emit-events.h',
-                                  'doc-good-qapi-events.c', 'doc-good-qapi-events.h',
-                                  'doc-good-qapi-init-commands.c', 'doc-good-qapi-init-commands.h',
-                                  'doc-good-qapi-introspect.c', 'doc-good-qapi-introspect.h',
-                                  'doc-good-qapi-types.c', 'doc-good-qapi-types.h',
-                                  'doc-good-qapi-visit.c', 'doc-good-qapi-visit.h' ],
-                         input: files('doc-good.json'),
-                         command: [ qapi_gen, '-o', meson.current_build_dir(),
-                                    '-p', 'doc-good-', '@INPUT0@' ],
-                         depend_files: qapi_gen_depends)
+custom_target('QAPI doc',
+              output: ['doc-good-qapi-commands.c', 'doc-good-qapi-commands.h',
+                       'doc-good-qapi-emit-events.c', 'doc-good-qapi-emit-events.h',
+                       'doc-good-qapi-events.c', 'doc-good-qapi-events.h',
+                       'doc-good-qapi-init-commands.c', 'doc-good-qapi-init-commands.h',
+                       'doc-good-qapi-introspect.c', 'doc-good-qapi-introspect.h',
+                       'doc-good-qapi-types.c', 'doc-good-qapi-types.h',
+                       'doc-good-qapi-visit.c', 'doc-good-qapi-visit.h' ],
+              input: files('doc-good.json'),
+              command: [ qapi_gen, '-o', meson.current_build_dir(),
+                         '-p', 'doc-good-', '@INPUT0@' ],
+              depend_files: qapi_gen_depends)
 
 if build_docs
   # Test the document-comment document generation code by running a test schema
-- 
2.37.1

Re: [PATCH] meson: remove dead assignments

Posted by Marc-André Lureau 3 years, 5 months ago

On Thu, Aug 18, 2022 at 1:44 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> Found with "muon analyze".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  plugins/meson.build           |  2 +-
>  tests/fp/meson.build          |  2 +-
>  tests/qapi-schema/meson.build | 24 ++++++++++++------------
>  3 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/plugins/meson.build b/plugins/meson.build
> index fa12047327..752377c66d 100644
> --- a/plugins/meson.build
> +++ b/plugins/meson.build
> @@ -2,7 +2,7 @@ plugin_ldflags = []
>  # Modules need more symbols than just those in
> plugins/qemu-plugins.symbols
>  if not enable_modules
>    if targetos == 'darwin'
> -    qemu_plugins_symbols_list = configure_file(
> +    configure_file(
>        input: files('qemu-plugins.symbols'),
>        output: 'qemu-plugins-ld64.symbols',
>        capture: true,
> diff --git a/tests/fp/meson.build b/tests/fp/meson.build
> index 2b4f00b916..6258e2bd7d 100644
> --- a/tests/fp/meson.build
> +++ b/tests/fp/meson.build
> @@ -632,7 +632,7 @@ test('fp-test-mulAdd', fptest,
>             ['f16_mulAdd', 'f32_mulAdd', 'f64_mulAdd', 'f128_mulAdd'],
>       suite: ['softfloat-slow', 'softfloat-ops-slow', 'slow'], timeout: 90)
>
> -fpbench = executable(
> +executable(
>    'fp-bench',
>    ['fp-bench.c', '../../fpu/softfloat.c'],
>    link_with: [libtestfloat, libsoftfloat],
> diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build
> index c18dd7d02f..406bc7255d 100644
> --- a/tests/qapi-schema/meson.build
> +++ b/tests/qapi-schema/meson.build
> @@ -215,18 +215,18 @@ test('QAPI schema regression tests', python,
>
>  diff = find_program('diff')
>
> -qapi_doc = custom_target('QAPI doc',
> -                         output: ['doc-good-qapi-commands.c',
> 'doc-good-qapi-commands.h',
> -                                  'doc-good-qapi-emit-events.c',
> 'doc-good-qapi-emit-events.h',
> -                                  'doc-good-qapi-events.c',
> 'doc-good-qapi-events.h',
> -                                  'doc-good-qapi-init-commands.c',
> 'doc-good-qapi-init-commands.h',
> -                                  'doc-good-qapi-introspect.c',
> 'doc-good-qapi-introspect.h',
> -                                  'doc-good-qapi-types.c',
> 'doc-good-qapi-types.h',
> -                                  'doc-good-qapi-visit.c',
> 'doc-good-qapi-visit.h' ],
> -                         input: files('doc-good.json'),
> -                         command: [ qapi_gen, '-o',
> meson.current_build_dir(),
> -                                    '-p', 'doc-good-', '@INPUT0@' ],
> -                         depend_files: qapi_gen_depends)
> +custom_target('QAPI doc',
> +              output: ['doc-good-qapi-commands.c',
> 'doc-good-qapi-commands.h',
> +                       'doc-good-qapi-emit-events.c',
> 'doc-good-qapi-emit-events.h',
> +                       'doc-good-qapi-events.c', 'doc-good-qapi-events.h',
> +                       'doc-good-qapi-init-commands.c',
> 'doc-good-qapi-init-commands.h',
> +                       'doc-good-qapi-introspect.c',
> 'doc-good-qapi-introspect.h',
> +                       'doc-good-qapi-types.c', 'doc-good-qapi-types.h',
> +                       'doc-good-qapi-visit.c', 'doc-good-qapi-visit.h' ],
> +              input: files('doc-good.json'),
> +              command: [ qapi_gen, '-o', meson.current_build_dir(),
> +                         '-p', 'doc-good-', '@INPUT0@' ],
> +              depend_files: qapi_gen_depends)
>
>  if build_docs
>    # Test the document-comment document generation code by running a test
> schema
> --
> 2.37.1
>
>
>

-- 
Marc-André Lureau