[v1] Convert nanoMIPS disassembler from C++ to C

[PATCH 11/20] disas/nanomips: Remove #inlcude <sstream>

Posted by Milica Lazarevic 3 years, 5 months ago

<sstream> is a C++ library and it's not used by disassembler.

Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com>
---
 disas/nanomips.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
index cab53f482b..23db8177ef 100644
--- a/disas/nanomips.cpp
+++ b/disas/nanomips.cpp
@@ -32,7 +32,6 @@
 
 #include <cstring>
 #include <stdexcept>
-#include <sstream>
 #include <stdio.h>
 #include <stdarg.h>
 
-- 
2.25.1

Re: [PATCH 11/20] disas/nanomips: Remove #inlcude <sstream>

Posted by Thomas Huth 3 years, 5 months ago

On 15/08/2022 09.26, Milica Lazarevic wrote:
> <sstream> is a C++ library and it's not used by disassembler.
> 
> Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com>
> ---
>   disas/nanomips.cpp | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
> index cab53f482b..23db8177ef 100644
> --- a/disas/nanomips.cpp
> +++ b/disas/nanomips.cpp
> @@ -32,7 +32,6 @@
>   
>   #include <cstring>
>   #include <stdexcept>
> -#include <sstream>
>   #include <stdio.h>
>   #include <stdarg.h>

Reviewed-by: Thomas Huth <thuth@redhat.com>