[PATCH 1/3] Revert "usbredir: avoid queuing hello packet on snapshot restore"

Joelle van Dyne posted 3 patches 3 years, 5 months ago
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
[PATCH 1/3] Revert "usbredir: avoid queuing hello packet on snapshot restore"
Posted by Joelle van Dyne 3 years, 5 months ago
Run state is also in RUN_STATE_PRELAUNCH while "-S" is used.

This reverts commit 12d182898a4866e4be418e2abac286b497cfa1b2.

Signed-off-by: Joelle van Dyne <j@getutm.app>
---
 hw/usb/redirect.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 1bd30efc3e..fd7df599bc 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1280,8 +1280,7 @@ static void usbredir_create_parser(USBRedirDevice *dev)
     }
 #endif
 
-    if (runstate_check(RUN_STATE_INMIGRATE) ||
-        runstate_check(RUN_STATE_PRELAUNCH)) {
+    if (runstate_check(RUN_STATE_INMIGRATE)) {
         flags |= usbredirparser_fl_no_hello;
     }
     usbredirparser_init(dev->parser, VERSION, caps, USB_REDIR_CAPS_SIZE,
-- 
2.28.0
Re: [PATCH 1/3] Revert "usbredir: avoid queuing hello packet on snapshot restore"
Posted by Ján Tomko 3 years, 2 months ago
On a Friday in 2022, Joelle van Dyne wrote:
>Run state is also in RUN_STATE_PRELAUNCH while "-S" is used.
>
>This reverts commit 12d182898a4866e4be418e2abac286b497cfa1b2.
>
>Signed-off-by: Joelle van Dyne <j@getutm.app>
>---
> hw/usb/redirect.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)


Reviewed-by: Ján Tomko <jtomko@redhat.com>

This fixes usb redirect on VM startup for VMs started by libvirt, which
uses -S:
https://bugzilla.redhat.com/show_bug.cgi?id=2144436

Jano