[v2] parallels: Refactor the code of images checks and fix a bug

[PATCH v2 0/8] parallels: Refactor the code of images checks and fix a bug

Alexander Ivanov posted 8 patches 1 year, 8 months ago

Diff against v1 v1 v3 v5 v6 v7 v8 v9 v10 v11 v11
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220811150044.1704013-1-alexander.ivanov@virtuozzo.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, "Denis V. Lunev" <den@openvz.org>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

There is a newer version of this series

block/parallels.c | 188 ++++++++++++++++++++++++++++++++--------------
1 file changed, 132 insertions(+), 56 deletions(-)

Expand all Fold all

[PATCH v2 0/8] parallels: Refactor the code of images checks and fix a bug

Posted by Alexander Ivanov 1 year, 8 months ago

Fix image inflation when offset in BAT is out of image.

Replace whole BAT syncing by flushing only dirty blocks.

Move all the checks outside the main check function in
separate functions

Use WITH_QEMU_LOCK_GUARD for more clean code.

Alexander Ivanov (8):
  parallels: Out of image offset in BAT leads to image inflation
  parallels: Move BAT entry setting to a separate function
  parallels: Replace bdrv_co_pwrite_sync by bdrv_co_flush for BAT
    flushing
  parallels: Move check of unclean image to a separate function
  parallels: Move check of cluster outside image to a separate function
  parallels: Move check of leaks to a separate function
  parallels: Move statistic collection to a separate function
  parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD

 block/parallels.c | 188 ++++++++++++++++++++++++++++++++--------------
 1 file changed, 132 insertions(+), 56 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/8] parallels: Refactor the code of images checks and fix a bug

Posted by Denis V. Lunev 1 year, 8 months ago

On 11.08.2022 17:00, Alexander Ivanov wrote:
> Fix image inflation when offset in BAT is out of image.
>
> Replace whole BAT syncing by flushing only dirty blocks.
>
> Move all the checks outside the main check function in
> separate functions
>
> Use WITH_QEMU_LOCK_GUARD for more clean code.
>
> Alexander Ivanov (8):
>    parallels: Out of image offset in BAT leads to image inflation
>    parallels: Move BAT entry setting to a separate function
>    parallels: Replace bdrv_co_pwrite_sync by bdrv_co_flush for BAT
>      flushing
>    parallels: Move check of unclean image to a separate function
>    parallels: Move check of cluster outside image to a separate function
>    parallels: Move check of leaks to a separate function
>    parallels: Move statistic collection to a separate function
>    parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD
>
>   block/parallels.c | 188 ++++++++++++++++++++++++++++++++--------------
>   1 file changed, 132 insertions(+), 56 deletions(-)
>
I believe that this series is ready to go once commit
messages will be improved.

Den