tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

[PATCH] tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

Thomas Huth posted 1 patch 1 year, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220802123101.430757-1-thuth@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

tests/qemu-iotests/264 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

Posted by Thomas Huth 1 year, 9 months ago

It is possible to hit the assertTrue(delta_t < 2.0) on very loaded
systems. Increase the value to 5.0 to ease the situation a little bit.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 See also https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg03936.html

 tests/qemu-iotests/264 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/264 b/tests/qemu-iotests/264
index bc431d1a19..289381e315 100755
--- a/tests/qemu-iotests/264
+++ b/tests/qemu-iotests/264
@@ -101,7 +101,7 @@ class TestNbdReconnect(iotests.QMPTestCase):
         start_t = time.time()
         self.vm.event_wait('BLOCK_JOB_CANCELLED')
         delta_t = time.time() - start_t
-        self.assertTrue(delta_t < 2.0)
+        self.assertTrue(delta_t < 5.0)
 
     def test_mirror_cancel(self):
         # Mirror speed limit doesn't work well enough, it seems that mirror
-- 
2.31.1

Re: [PATCH] tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

Posted by Vladimir Sementsov-Ogievskiy 1 year, 9 months ago

On 8/2/22 15:31, Thomas Huth wrote:
> It is possible to hit the assertTrue(delta_t < 2.0) on very loaded
> systems. Increase the value to 5.0 to ease the situation a little bit.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   See also https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg03936.html
> 
>   tests/qemu-iotests/264 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/264 b/tests/qemu-iotests/264
> index bc431d1a19..289381e315 100755
> --- a/tests/qemu-iotests/264
> +++ b/tests/qemu-iotests/264
> @@ -101,7 +101,7 @@ class TestNbdReconnect(iotests.QMPTestCase):
>           start_t = time.time()
>           self.vm.event_wait('BLOCK_JOB_CANCELLED')
>           delta_t = time.time() - start_t
> -        self.assertTrue(delta_t < 2.0)
> +        self.assertTrue(delta_t < 5.0)
>   
>       def test_mirror_cancel(self):
>           # Mirror speed limit doesn't work well enough, it seems that mirror

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

-- 
Best regards,
Vladimir