ppc: Remove redundant macro MSR_BOOK3S_MASK.

[PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.

Yonggang Luo posted 1 patch 3 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220728201135.223-1-luoyonggang@gmail.com

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Daniel Henrique Barboza <danielhb413@gmail.com>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>

target/ppc/excp_helper.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.

Posted by Yonggang Luo 3 years, 4 months ago

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 target/ppc/excp_helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index cb752b184a..7550aafed6 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
     do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
 }
 
-#define MSR_BOOK3S_MASK
 #if defined(TARGET_PPC64)
 void helper_rfid(CPUPPCState *env)
 {
-- 
2.36.1.windows.1

Re: [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.

Posted by Laurent Vivier 3 years, 4 months ago

Le 28/07/2022 à 22:11, Yonggang Luo a écrit :
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>   target/ppc/excp_helper.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index cb752b184a..7550aafed6 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
>       do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
>   }
>   
> -#define MSR_BOOK3S_MASK
>   #if defined(TARGET_PPC64)
>   void helper_rfid(CPUPPCState *env)
>   {

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.

Posted by Daniel Henrique Barboza 3 years, 4 months ago


On 7/28/22 17:11, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>   target/ppc/excp_helper.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index cb752b184a..7550aafed6 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
>       do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
>   }
>   
> -#define MSR_BOOK3S_MASK

The tag was introduced by a2e71b28e832 ("ppc: Fix rfi/rfid/hrfi/... emulation").
Even back then it wasn't being used.


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


Laurent, I believe this is qemu-trivial material. Let me know if you want
me to get it via the ppc tree instead.


Daniel


>   #if defined(TARGET_PPC64)
>   void helper_rfid(CPUPPCState *env)
>   {