tests/qtest/bios-tables-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
OSK value is irrelevant for ACPI test case.
Supply fake OSK explicitly to prevent QEMU complaining about
invalid key when it fallbacks to default_osk.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 359916c228..7c5f736b51 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
.variant = ".applesmc",
};
- test_acpi_one("-device isa-applesmc", &data);
+ /* supply fake 64-byte OSK to silence missing key warning */
+ test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
+ "topreventinvalidkeywarningsonstderr", &data);
free_test_data(&data);
}
--
2.31.1
On Thu, 28 Jul 2022 09:37:13 -0400 Igor Mammedov <imammedo@redhat.com> wrote: > OSK value is irrelevant for ACPI test case. > Supply fake OSK explicitly to prevent QEMU complaining about > invalid key when it fallbacks to default_osk. > > Suggested-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Igor Mammedov <imammedo@redhat.com> Michael, can you pick it up? > --- > tests/qtest/bios-tables-test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 359916c228..7c5f736b51 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void) > .variant = ".applesmc", > }; > > - test_acpi_one("-device isa-applesmc", &data); > + /* supply fake 64-byte OSK to silence missing key warning */ > + test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough" > + "topreventinvalidkeywarningsonstderr", &data); > free_test_data(&data); > } >
On Tue, Aug 09, 2022 at 01:40:24PM +0200, Igor Mammedov wrote: > On Thu, 28 Jul 2022 09:37:13 -0400 > Igor Mammedov <imammedo@redhat.com> wrote: > > > OSK value is irrelevant for ACPI test case. > > Supply fake OSK explicitly to prevent QEMU complaining about > > invalid key when it fallbacks to default_osk. > > > > Suggested-by: Daniel P. Berrangé <berrange@redhat.com> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > Michael, > can you pick it up? Yes! In the next pull. I was hoping the linux seed thing will settle but apparently no luck ... > > --- > > tests/qtest/bios-tables-test.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > > index 359916c228..7c5f736b51 100644 > > --- a/tests/qtest/bios-tables-test.c > > +++ b/tests/qtest/bios-tables-test.c > > @@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void) > > .variant = ".applesmc", > > }; > > > > - test_acpi_one("-device isa-applesmc", &data); > > + /* supply fake 64-byte OSK to silence missing key warning */ > > + test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough" > > + "topreventinvalidkeywarningsonstderr", &data); > > free_test_data(&data); > > } > >
On Thu, Jul 28, 2022 at 09:37:13AM -0400, Igor Mammedov wrote: > OSK value is irrelevant for ACPI test case. > Supply fake OSK explicitly to prevent QEMU complaining about > invalid key when it fallbacks to default_osk. > > Suggested-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > --- > tests/qtest/bios-tables-test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 359916c228..7c5f736b51 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void) > .variant = ".applesmc", > }; > > - test_acpi_one("-device isa-applesmc", &data); > + /* supply fake 64-byte OSK to silence missing key warning */ > + test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough" > + "topreventinvalidkeywarningsonstderr", &data); > free_test_data(&data); > } All 64 chars present and correct. Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
© 2016 - 2024 Red Hat, Inc.