[v3] migration-test: Allow test to run without uffd

[PATCH v3 0/2] migration-test: Allow test to run without uffd

Posted by Peter Xu 1 year, 9 months ago

v2:
- Fix warning in patch 1 [Thomas]
- Collected R-b for Daniel

Compare to v1, this added a new patch as reported by Thomas to (hopefully)
allow auto-converge test to pass on some MacOS testbeds.

Please review, thanks.

Peter Xu (2):
  migration-test: Use migrate_ensure_converge() for auto-converge
  migration-test: Allow test to run without uffd

 tests/qtest/migration-test.c | 67 +++++++++++++++---------------------
 1 file changed, 27 insertions(+), 40 deletions(-)

-- 
2.32.0

Re: [PATCH v3 0/2] migration-test: Allow test to run without uffd

Posted by Thomas Huth 1 year, 9 months ago

On 28/07/2022 15.35, Peter Xu wrote:
> v2:
> - Fix warning in patch 1 [Thomas]
> - Collected R-b for Daniel
> 
> Compare to v1, this added a new patch as reported by Thomas to (hopefully)
> allow auto-converge test to pass on some MacOS testbeds.
> 
> Please review, thanks.
> 
> Peter Xu (2):
>    migration-test: Use migrate_ensure_converge() for auto-converge
>    migration-test: Allow test to run without uffd
> 
>   tests/qtest/migration-test.c | 67 +++++++++++++++---------------------
>   1 file changed, 27 insertions(+), 40 deletions(-)

Thanks, I've queued this to my testing-next branch now:

  https://gitlab.com/thuth/qemu/-/commits/testing-next/

  Thomas

Re: [PATCH v3 0/2] migration-test: Allow test to run without uffd

Posted by Thomas Huth 1 year, 9 months ago

On 28/07/2022 15.35, Peter Xu wrote:
> v2:
> - Fix warning in patch 1 [Thomas]
> - Collected R-b for Daniel
> 
> Compare to v1, this added a new patch as reported by Thomas to (hopefully)
> allow auto-converge test to pass on some MacOS testbeds.
> 
> Please review, thanks.
> 
> Peter Xu (2):
>    migration-test: Use migrate_ensure_converge() for auto-converge
>    migration-test: Allow test to run without uffd
> 
>   tests/qtest/migration-test.c | 67 +++++++++++++++---------------------
>   1 file changed, 27 insertions(+), 40 deletions(-)

Seems to work now:

https://api.cirrus-ci.com/v1/task/4760264934424576/logs/build.log

Citing:

" 2/59 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test         OK 
         218.87s   33 subtests passed"

Tested-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH v3 0/2] migration-test: Allow test to run without uffd

Posted by Peter Xu 1 year, 9 months ago

On Thu, Jul 28, 2022 at 04:44:49PM +0200, Thomas Huth wrote:
> On 28/07/2022 15.35, Peter Xu wrote:
> > v2:
> > - Fix warning in patch 1 [Thomas]
> > - Collected R-b for Daniel
> > 
> > Compare to v1, this added a new patch as reported by Thomas to (hopefully)
> > allow auto-converge test to pass on some MacOS testbeds.
> > 
> > Please review, thanks.
> > 
> > Peter Xu (2):
> >    migration-test: Use migrate_ensure_converge() for auto-converge
> >    migration-test: Allow test to run without uffd
> > 
> >   tests/qtest/migration-test.c | 67 +++++++++++++++---------------------
> >   1 file changed, 27 insertions(+), 40 deletions(-)
> 
> Seems to work now:
> 
> https://api.cirrus-ci.com/v1/task/4760264934424576/logs/build.log
> 
> Citing:
> 
> " 2/59 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test         OK
> 218.87s   33 subtests passed"
> 
> Tested-by: Thomas Huth <thuth@redhat.com>

Thanks!

-- 
Peter Xu