[v7] block: cleanup backing and file handling

[PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

Vladimir Sementsov-Ogievskiy posted 15 patches 1 year, 9 months ago

Diff against v1 v6
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220726201134.924743-1-vsementsov@yandex-team.ru

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Ari Sundholm <ari@tuxera.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, "Denis V. Lunev" <den@openvz.org>, Wen Congyang <wencongyang2@huawei.com>, Xie Changlong <xiechanglong.d@gmail.com>, Stefan Weil <sw@weilnetz.de>, Jeff Cody <codyprime@gmail.com>, Fam Zheng <fam@euphon.net>

block.c                            | 435 ++++++++++-------------------
block/blkdebug.c                   |   9 +-
block/blklogwrites.c               |  11 +-
block/blkreplay.c                  |   7 +-
block/blkverify.c                  |   9 +-
block/bochs.c                      |   7 +-
block/cloop.c                      |   7 +-
block/commit.c                     |   1 +
block/copy-before-write.c          |   9 +-
block/copy-on-read.c               |   9 +-
block/crypto.c                     |  11 +-
block/dmg.c                        |   7 +-
block/filter-compress.c            |   8 +-
block/mirror.c                     |   1 +
block/parallels.c                  |   7 +-
block/preallocate.c                |   9 +-
block/qcow.c                       |   6 +-
block/qcow2.c                      |   8 +-
block/qed.c                        |   8 +-
block/raw-format.c                 |   4 +-
block/replication.c                |   8 +-
block/snapshot-access.c            |   6 +-
block/snapshot.c                   |  59 ++--
block/throttle.c                   |   8 +-
block/vdi.c                        |   7 +-
block/vhdx.c                       |   7 +-
block/vmdk.c                       |   7 +-
block/vpc.c                        |   7 +-
include/block/block-common.h       |  39 +++
include/block/block-global-state.h |   3 +
include/block/block_int-common.h   |  29 +-
tests/unit/test-bdrv-drain.c       |  11 +-
tests/unit/test-bdrv-graph-mod.c   | 104 ++++---
33 files changed, 389 insertions(+), 479 deletions(-)

Expand all Fold all

[PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

Posted by Vladimir Sementsov-Ogievskiy 1 year, 9 months ago

Hi all!

That's the first part of
"[PATCH v5 00/45] Transactional block-graph modifying API",
updated and is fully reviewed by Hanna.

v7: add r-bs and rebase on master

Vladimir Sementsov-Ogievskiy (15):
  block: BlockDriver: add .filtered_child_is_backing field
  block: introduce bdrv_open_file_child() helper
  block/blklogwrites: don't care to remove bs->file child on failure
  test-bdrv-graph-mod: update test_parallel_perm_update test case
  tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing
  test-bdrv-graph-mod: fix filters to be filters
  block: document connection between child roles and
    bs->backing/bs->file
  block/snapshot: stress that we fallback to primary child
  Revert "block: Let replace_child_noperm free children"
  Revert "block: Let replace_child_tran keep indirect pointer"
  Revert "block: Restructure remove_file_or_backing_child()"
  Revert "block: Pass BdrvChild ** to replace_child_noperm"
  block: Manipulate bs->file / bs->backing pointers in .attach/.detach
  block/snapshot: drop indirection around bdrv_snapshot_fallback_ptr
  block: refactor bdrv_remove_file_or_backing_child to bdrv_remove_child

 block.c                            | 435 ++++++++++-------------------
 block/blkdebug.c                   |   9 +-
 block/blklogwrites.c               |  11 +-
 block/blkreplay.c                  |   7 +-
 block/blkverify.c                  |   9 +-
 block/bochs.c                      |   7 +-
 block/cloop.c                      |   7 +-
 block/commit.c                     |   1 +
 block/copy-before-write.c          |   9 +-
 block/copy-on-read.c               |   9 +-
 block/crypto.c                     |  11 +-
 block/dmg.c                        |   7 +-
 block/filter-compress.c            |   8 +-
 block/mirror.c                     |   1 +
 block/parallels.c                  |   7 +-
 block/preallocate.c                |   9 +-
 block/qcow.c                       |   6 +-
 block/qcow2.c                      |   8 +-
 block/qed.c                        |   8 +-
 block/raw-format.c                 |   4 +-
 block/replication.c                |   8 +-
 block/snapshot-access.c            |   6 +-
 block/snapshot.c                   |  59 ++--
 block/throttle.c                   |   8 +-
 block/vdi.c                        |   7 +-
 block/vhdx.c                       |   7 +-
 block/vmdk.c                       |   7 +-
 block/vpc.c                        |   7 +-
 include/block/block-common.h       |  39 +++
 include/block/block-global-state.h |   3 +
 include/block/block_int-common.h   |  29 +-
 tests/unit/test-bdrv-drain.c       |  11 +-
 tests/unit/test-bdrv-graph-mod.c   | 104 ++++---
 33 files changed, 389 insertions(+), 479 deletions(-)

-- 
2.25.1

Re: [PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

Posted by Kevin Wolf 1 year, 6 months ago

Am 26.07.2022 um 22:11 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
> 
> That's the first part of
> "[PATCH v5 00/45] Transactional block-graph modifying API",
> updated and is fully reviewed by Hanna.
> 
> v7: add r-bs and rebase on master

Thanks, applied to the block branch.

Kevin

Re: [PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

Posted by Vladimir Sementsov-Ogievskiy 1 year, 7 months ago

ping. Seems, all patches are reviewed

On 7/26/22 23:11, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> That's the first part of
> "[PATCH v5 00/45] Transactional block-graph modifying API",
> updated and is fully reviewed by Hanna.
> 
> v7: add r-bs and rebase on master
> 
> Vladimir Sementsov-Ogievskiy (15):
>    block: BlockDriver: add .filtered_child_is_backing field
>    block: introduce bdrv_open_file_child() helper
>    block/blklogwrites: don't care to remove bs->file child on failure
>    test-bdrv-graph-mod: update test_parallel_perm_update test case
>    tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing
>    test-bdrv-graph-mod: fix filters to be filters
>    block: document connection between child roles and
>      bs->backing/bs->file
>    block/snapshot: stress that we fallback to primary child
>    Revert "block: Let replace_child_noperm free children"
>    Revert "block: Let replace_child_tran keep indirect pointer"
>    Revert "block: Restructure remove_file_or_backing_child()"
>    Revert "block: Pass BdrvChild ** to replace_child_noperm"
>    block: Manipulate bs->file / bs->backing pointers in .attach/.detach
>    block/snapshot: drop indirection around bdrv_snapshot_fallback_ptr
>    block: refactor bdrv_remove_file_or_backing_child to bdrv_remove_child
> 
>   block.c                            | 435 ++++++++++-------------------
>   block/blkdebug.c                   |   9 +-
>   block/blklogwrites.c               |  11 +-
>   block/blkreplay.c                  |   7 +-
>   block/blkverify.c                  |   9 +-
>   block/bochs.c                      |   7 +-
>   block/cloop.c                      |   7 +-
>   block/commit.c                     |   1 +
>   block/copy-before-write.c          |   9 +-
>   block/copy-on-read.c               |   9 +-
>   block/crypto.c                     |  11 +-
>   block/dmg.c                        |   7 +-
>   block/filter-compress.c            |   8 +-
>   block/mirror.c                     |   1 +
>   block/parallels.c                  |   7 +-
>   block/preallocate.c                |   9 +-
>   block/qcow.c                       |   6 +-
>   block/qcow2.c                      |   8 +-
>   block/qed.c                        |   8 +-
>   block/raw-format.c                 |   4 +-
>   block/replication.c                |   8 +-
>   block/snapshot-access.c            |   6 +-
>   block/snapshot.c                   |  59 ++--
>   block/throttle.c                   |   8 +-
>   block/vdi.c                        |   7 +-
>   block/vhdx.c                       |   7 +-
>   block/vmdk.c                       |   7 +-
>   block/vpc.c                        |   7 +-
>   include/block/block-common.h       |  39 +++
>   include/block/block-global-state.h |   3 +
>   include/block/block_int-common.h   |  29 +-
>   tests/unit/test-bdrv-drain.c       |  11 +-
>   tests/unit/test-bdrv-graph-mod.c   | 104 ++++---
>   33 files changed, 389 insertions(+), 479 deletions(-)
> 


-- 
Best regards,
Vladimir

Re: [PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

Posted by Vladimir Sementsov-Ogievskiy 1 year, 6 months ago

ping

On 9/19/22 20:20, Vladimir Sementsov-Ogievskiy wrote:
> ping. Seems, all patches are reviewed
> 
> On 7/26/22 23:11, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> That's the first part of
>> "[PATCH v5 00/45] Transactional block-graph modifying API",
>> updated and is fully reviewed by Hanna.
>>
>> v7: add r-bs and rebase on master
>>
>> Vladimir Sementsov-Ogievskiy (15):
>>    block: BlockDriver: add .filtered_child_is_backing field
>>    block: introduce bdrv_open_file_child() helper
>>    block/blklogwrites: don't care to remove bs->file child on failure
>>    test-bdrv-graph-mod: update test_parallel_perm_update test case
>>    tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing
>>    test-bdrv-graph-mod: fix filters to be filters
>>    block: document connection between child roles and
>>      bs->backing/bs->file
>>    block/snapshot: stress that we fallback to primary child
>>    Revert "block: Let replace_child_noperm free children"
>>    Revert "block: Let replace_child_tran keep indirect pointer"
>>    Revert "block: Restructure remove_file_or_backing_child()"
>>    Revert "block: Pass BdrvChild ** to replace_child_noperm"
>>    block: Manipulate bs->file / bs->backing pointers in .attach/.detach
>>    block/snapshot: drop indirection around bdrv_snapshot_fallback_ptr
>>    block: refactor bdrv_remove_file_or_backing_child to bdrv_remove_child
>>
>>   block.c                            | 435 ++++++++++-------------------
>>   block/blkdebug.c                   |   9 +-
>>   block/blklogwrites.c               |  11 +-
>>   block/blkreplay.c                  |   7 +-
>>   block/blkverify.c                  |   9 +-
>>   block/bochs.c                      |   7 +-
>>   block/cloop.c                      |   7 +-
>>   block/commit.c                     |   1 +
>>   block/copy-before-write.c          |   9 +-
>>   block/copy-on-read.c               |   9 +-
>>   block/crypto.c                     |  11 +-
>>   block/dmg.c                        |   7 +-
>>   block/filter-compress.c            |   8 +-
>>   block/mirror.c                     |   1 +
>>   block/parallels.c                  |   7 +-
>>   block/preallocate.c                |   9 +-
>>   block/qcow.c                       |   6 +-
>>   block/qcow2.c                      |   8 +-
>>   block/qed.c                        |   8 +-
>>   block/raw-format.c                 |   4 +-
>>   block/replication.c                |   8 +-
>>   block/snapshot-access.c            |   6 +-
>>   block/snapshot.c                   |  59 ++--
>>   block/throttle.c                   |   8 +-
>>   block/vdi.c                        |   7 +-
>>   block/vhdx.c                       |   7 +-
>>   block/vmdk.c                       |   7 +-
>>   block/vpc.c                        |   7 +-
>>   include/block/block-common.h       |  39 +++
>>   include/block/block-global-state.h |   3 +
>>   include/block/block_int-common.h   |  29 +-
>>   tests/unit/test-bdrv-drain.c       |  11 +-
>>   tests/unit/test-bdrv-graph-mod.c   | 104 ++++---
>>   33 files changed, 389 insertions(+), 479 deletions(-)
>>
> 
> 

-- 
Best regards,
Vladimir