1. Patchew
  2. QEMU
  3. View series

[PATCH v2 0/8] AArch64/HMAT support and tests

Hesham Almatary posted 8 patches 1 year, 9 months ago
Failed in applying to current master (apply log)
Maintainers: Peter Maydell <peter.maydell@linaro.org>, Shannon Zhao <shannon.zhaosl@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Yanan Wang <wangyanan55@huawei.com>
There is a newer version of this series
hw/arm/Kconfig                                |   1 +
hw/arm/virt-acpi-build.c                      |   7 ++
hw/core/machine.c                             |   4 +-
tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes
tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes
tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes
tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes
tests/data/acpi/virt/APIC.acpihmatvirt        | Bin 0 -> 396 bytes
tests/data/acpi/virt/DSDT.acpihmatvirt        | Bin 0 -> 5282 bytes
tests/data/acpi/virt/HMAT.acpihmatvirt        | Bin 0 -> 288 bytes
tests/data/acpi/virt/PPTT.acpihmatvirt        | Bin 0 -> 196 bytes
tests/data/acpi/virt/SRAT.acpihmatvirt        | Bin 0 -> 240 bytes
tests/qtest/bios-tables-test.c                | 109 ++++++++++++++++++
13 files changed, 118 insertions(+), 3 deletions(-)
create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator
create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator
create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator
create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator
create mode 100644 tests/data/acpi/virt/APIC.acpihmatvirt
create mode 100644 tests/data/acpi/virt/DSDT.acpihmatvirt
create mode 100644 tests/data/acpi/virt/HMAT.acpihmatvirt
create mode 100644 tests/data/acpi/virt/PPTT.acpihmatvirt
create mode 100644 tests/data/acpi/virt/SRAT.acpihmatvirt
[PATCH v2 0/8] AArch64/HMAT support and tests
Posted by Hesham Almatary 1 year, 9 months ago 
This patchset adds support for AArch64/HMAT including a test.
It relies on other two patch sets from:

Brice Goglin: to support -numa without initiators on q35/x86.
  https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf678@inria.fr/
Xiang Chen: to enable/support HMAT on AArch64.
  https://lore.kernel.org/all/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/

I further add a test with ACPI/HMAT tables that uses the two
patch sets.

Changes from v1:
- Generate APIC and PPTT ACPI tables for AArch64/virt
- Avoid using legacy syntax in numa/bios tests
- Delete unchanged FACP tables

Brice Goglin (4):
  hmat acpi: Don't require initiator value in -numa
  tests: acpi: add and whitelist *.hmat-noinitiator expected blobs
  tests: acpi: q35: add test for hmat nodes without initiators
  tests: acpi: q35: update expected blobs *.hmat-noinitiators expected
    HMAT:

Hesham Almatary (3):
  tests: Add HMAT AArch64/virt empty table files
  tests: acpi: aarch64/virt: add a test for hmat nodes with no initiators
  tests: virt: Update expected *.acpihmatvirt tables

Xiang Chen (1):
  hw/arm/virt: Enable HMAT on arm virt machine

 hw/arm/Kconfig                                |   1 +
 hw/arm/virt-acpi-build.c                      |   7 ++
 hw/core/machine.c                             |   4 +-
 tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes
 tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes
 tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes
 tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes
 tests/data/acpi/virt/APIC.acpihmatvirt        | Bin 0 -> 396 bytes
 tests/data/acpi/virt/DSDT.acpihmatvirt        | Bin 0 -> 5282 bytes
 tests/data/acpi/virt/HMAT.acpihmatvirt        | Bin 0 -> 288 bytes
 tests/data/acpi/virt/PPTT.acpihmatvirt        | Bin 0 -> 196 bytes
 tests/data/acpi/virt/SRAT.acpihmatvirt        | Bin 0 -> 240 bytes
 tests/qtest/bios-tables-test.c                | 109 ++++++++++++++++++
 13 files changed, 118 insertions(+), 3 deletions(-)
 create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator
 create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator
 create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator
 create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator
 create mode 100644 tests/data/acpi/virt/APIC.acpihmatvirt
 create mode 100644 tests/data/acpi/virt/DSDT.acpihmatvirt
 create mode 100644 tests/data/acpi/virt/HMAT.acpihmatvirt
 create mode 100644 tests/data/acpi/virt/PPTT.acpihmatvirt
 create mode 100644 tests/data/acpi/virt/SRAT.acpihmatvirt

-- 
2.25.1
Re: [PATCH v2 0/8] AArch64/HMAT support and tests
Posted by Yicong Yang via 1 year, 7 months ago 
On 2022/7/19 17:49, Hesham Almatary wrote:
> This patchset adds support for AArch64/HMAT including a test.
> It relies on other two patch sets from:
> 
> Brice Goglin: to support -numa without initiators on q35/x86.
>   https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf678@inria.fr/
> Xiang Chen: to enable/support HMAT on AArch64.
>   https://lore.kernel.org/all/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/
> 
> I further add a test with ACPI/HMAT tables that uses the two
> patch sets.
> 

Hi Hesham,

I've used this feature locally for a period on aarch64 and it works fine. Also tested the qemu
test added based on v7.1.0-rc4 and `make test` show:

108/130 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test          OK              99.80s   7 subtests passed

Wish to see this in mainline!

Tested-by: Yicong Yang <yangyicong@hisilicon.com>

Thanks!

> Changes from v1:
> - Generate APIC and PPTT ACPI tables for AArch64/virt
> - Avoid using legacy syntax in numa/bios tests
> - Delete unchanged FACP tables
> 
> Brice Goglin (4):
>   hmat acpi: Don't require initiator value in -numa
>   tests: acpi: add and whitelist *.hmat-noinitiator expected blobs
>   tests: acpi: q35: add test for hmat nodes without initiators
>   tests: acpi: q35: update expected blobs *.hmat-noinitiators expected
>     HMAT:
> 
> Hesham Almatary (3):
>   tests: Add HMAT AArch64/virt empty table files
>   tests: acpi: aarch64/virt: add a test for hmat nodes with no initiators
>   tests: virt: Update expected *.acpihmatvirt tables
> 
> Xiang Chen (1):
>   hw/arm/virt: Enable HMAT on arm virt machine
> 
>  hw/arm/Kconfig                                |   1 +
>  hw/arm/virt-acpi-build.c                      |   7 ++
>  hw/core/machine.c                             |   4 +-
>  tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes
>  tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes
>  tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes
>  tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes
>  tests/data/acpi/virt/APIC.acpihmatvirt        | Bin 0 -> 396 bytes
>  tests/data/acpi/virt/DSDT.acpihmatvirt        | Bin 0 -> 5282 bytes
>  tests/data/acpi/virt/HMAT.acpihmatvirt        | Bin 0 -> 288 bytes
>  tests/data/acpi/virt/PPTT.acpihmatvirt        | Bin 0 -> 196 bytes
>  tests/data/acpi/virt/SRAT.acpihmatvirt        | Bin 0 -> 240 bytes
>  tests/qtest/bios-tables-test.c                | 109 ++++++++++++++++++
>  13 files changed, 118 insertions(+), 3 deletions(-)
>  create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/virt/APIC.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/DSDT.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/HMAT.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/PPTT.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/SRAT.acpihmatvirt
>
Re: [PATCH v2 0/8] AArch64/HMAT support and tests
Posted by Michael S. Tsirkin 1 year, 9 months ago 
On Tue, Jul 19, 2022 at 10:49:42AM +0100, Hesham Almatary wrote:
> This patchset adds support for AArch64/HMAT including a test.
> It relies on other two patch sets from:
> 
> Brice Goglin: to support -numa without initiators on q35/x86.
>   https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf678@inria.fr/
> Xiang Chen: to enable/support HMAT on AArch64.
>   https://lore.kernel.org/all/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/

Thanks!
I think it's best to merge this all after the release.
I've tagged this but please ping me after the release
just to make sure. Thanks everyone!

> I further add a test with ACPI/HMAT tables that uses the two
> patch sets.
> 
> Changes from v1:
> - Generate APIC and PPTT ACPI tables for AArch64/virt
> - Avoid using legacy syntax in numa/bios tests
> - Delete unchanged FACP tables
> 
> Brice Goglin (4):
>   hmat acpi: Don't require initiator value in -numa
>   tests: acpi: add and whitelist *.hmat-noinitiator expected blobs
>   tests: acpi: q35: add test for hmat nodes without initiators
>   tests: acpi: q35: update expected blobs *.hmat-noinitiators expected
>     HMAT:
> 
> Hesham Almatary (3):
>   tests: Add HMAT AArch64/virt empty table files
>   tests: acpi: aarch64/virt: add a test for hmat nodes with no initiators
>   tests: virt: Update expected *.acpihmatvirt tables
> 
> Xiang Chen (1):
>   hw/arm/virt: Enable HMAT on arm virt machine
> 
>  hw/arm/Kconfig                                |   1 +
>  hw/arm/virt-acpi-build.c                      |   7 ++
>  hw/core/machine.c                             |   4 +-
>  tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes
>  tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes
>  tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes
>  tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes
>  tests/data/acpi/virt/APIC.acpihmatvirt        | Bin 0 -> 396 bytes
>  tests/data/acpi/virt/DSDT.acpihmatvirt        | Bin 0 -> 5282 bytes
>  tests/data/acpi/virt/HMAT.acpihmatvirt        | Bin 0 -> 288 bytes
>  tests/data/acpi/virt/PPTT.acpihmatvirt        | Bin 0 -> 196 bytes
>  tests/data/acpi/virt/SRAT.acpihmatvirt        | Bin 0 -> 240 bytes
>  tests/qtest/bios-tables-test.c                | 109 ++++++++++++++++++
>  13 files changed, 118 insertions(+), 3 deletions(-)
>  create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator
>  create mode 100644 tests/data/acpi/virt/APIC.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/DSDT.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/HMAT.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/PPTT.acpihmatvirt
>  create mode 100644 tests/data/acpi/virt/SRAT.acpihmatvirt
> 
> -- 
> 2.25.1
Re: [PATCH v2 0/8] AArch64/HMAT support and tests
Posted by Hesham Almatary via 1 year, 7 months ago 
Hello Michael,

On 7/26/2022 4:04 PM, Michael S. Tsirkin wrote:
> On Tue, Jul 19, 2022 at 10:49:42AM +0100, Hesham Almatary wrote:
>> This patchset adds support for AArch64/HMAT including a test.
>> It relies on other two patch sets from:
>>
>> Brice Goglin: to support -numa without initiators on q35/x86.
>>    https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf678@inria.fr/
>> Xiang Chen: to enable/support HMAT on AArch64.
>>    https://lore.kernel.org/all/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/
> Thanks!
> I think it's best to merge this all after the release.
> I've tagged this but please ping me after the release
> just to make sure. Thanks everyone!
Ping
>> I further add a test with ACPI/HMAT tables that uses the two
>> patch sets.
>>
>> Changes from v1:
>> - Generate APIC and PPTT ACPI tables for AArch64/virt
>> - Avoid using legacy syntax in numa/bios tests
>> - Delete unchanged FACP tables
>>
>> Brice Goglin (4):
>>    hmat acpi: Don't require initiator value in -numa
>>    tests: acpi: add and whitelist *.hmat-noinitiator expected blobs
>>    tests: acpi: q35: add test for hmat nodes without initiators
>>    tests: acpi: q35: update expected blobs *.hmat-noinitiators expected
>>      HMAT:
>>
>> Hesham Almatary (3):
>>    tests: Add HMAT AArch64/virt empty table files
>>    tests: acpi: aarch64/virt: add a test for hmat nodes with no initiators
>>    tests: virt: Update expected *.acpihmatvirt tables
>>
>> Xiang Chen (1):
>>    hw/arm/virt: Enable HMAT on arm virt machine
>>
>>   hw/arm/Kconfig                                |   1 +
>>   hw/arm/virt-acpi-build.c                      |   7 ++
>>   hw/core/machine.c                             |   4 +-
>>   tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes
>>   tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes
>>   tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes
>>   tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes
>>   tests/data/acpi/virt/APIC.acpihmatvirt        | Bin 0 -> 396 bytes
>>   tests/data/acpi/virt/DSDT.acpihmatvirt        | Bin 0 -> 5282 bytes
>>   tests/data/acpi/virt/HMAT.acpihmatvirt        | Bin 0 -> 288 bytes
>>   tests/data/acpi/virt/PPTT.acpihmatvirt        | Bin 0 -> 196 bytes
>>   tests/data/acpi/virt/SRAT.acpihmatvirt        | Bin 0 -> 240 bytes
>>   tests/qtest/bios-tables-test.c                | 109 ++++++++++++++++++
>>   13 files changed, 118 insertions(+), 3 deletions(-)
>>   create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/virt/APIC.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/DSDT.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/HMAT.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/PPTT.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/SRAT.acpihmatvirt
>>
>> -- 
>> 2.25.1
>
Re: [PATCH v2 0/8] AArch64/HMAT support and tests
Posted by Hesham Almatary via 1 year, 8 months ago 
Hello Michael,

On 7/26/2022 4:04 PM, Michael S. Tsirkin wrote:
> On Tue, Jul 19, 2022 at 10:49:42AM +0100, Hesham Almatary wrote:
>> This patchset adds support for AArch64/HMAT including a test.
>> It relies on other two patch sets from:
>>
>> Brice Goglin: to support -numa without initiators on q35/x86.
>>    https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf678@inria.fr/
>> Xiang Chen: to enable/support HMAT on AArch64.
>>    https://lore.kernel.org/all/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/
> Thanks!
> I think it's best to merge this all after the release.
> I've tagged this but please ping me after the release
> just to make sure. Thanks everyone!

Just a reminder of that could make it now.


>> I further add a test with ACPI/HMAT tables that uses the two
>> patch sets.
>>
>> Changes from v1:
>> - Generate APIC and PPTT ACPI tables for AArch64/virt
>> - Avoid using legacy syntax in numa/bios tests
>> - Delete unchanged FACP tables
>>
>> Brice Goglin (4):
>>    hmat acpi: Don't require initiator value in -numa
>>    tests: acpi: add and whitelist *.hmat-noinitiator expected blobs
>>    tests: acpi: q35: add test for hmat nodes without initiators
>>    tests: acpi: q35: update expected blobs *.hmat-noinitiators expected
>>      HMAT:
>>
>> Hesham Almatary (3):
>>    tests: Add HMAT AArch64/virt empty table files
>>    tests: acpi: aarch64/virt: add a test for hmat nodes with no initiators
>>    tests: virt: Update expected *.acpihmatvirt tables
>>
>> Xiang Chen (1):
>>    hw/arm/virt: Enable HMAT on arm virt machine
>>
>>   hw/arm/Kconfig                                |   1 +
>>   hw/arm/virt-acpi-build.c                      |   7 ++
>>   hw/core/machine.c                             |   4 +-
>>   tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes
>>   tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes
>>   tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes
>>   tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes
>>   tests/data/acpi/virt/APIC.acpihmatvirt        | Bin 0 -> 396 bytes
>>   tests/data/acpi/virt/DSDT.acpihmatvirt        | Bin 0 -> 5282 bytes
>>   tests/data/acpi/virt/HMAT.acpihmatvirt        | Bin 0 -> 288 bytes
>>   tests/data/acpi/virt/PPTT.acpihmatvirt        | Bin 0 -> 196 bytes
>>   tests/data/acpi/virt/SRAT.acpihmatvirt        | Bin 0 -> 240 bytes
>>   tests/qtest/bios-tables-test.c                | 109 ++++++++++++++++++
>>   13 files changed, 118 insertions(+), 3 deletions(-)
>>   create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator
>>   create mode 100644 tests/data/acpi/virt/APIC.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/DSDT.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/HMAT.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/PPTT.acpihmatvirt
>>   create mode 100644 tests/data/acpi/virt/SRAT.acpihmatvirt
>>
>> -- 
>> 2.25.1
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.