[PULL 0/2] Hexagon (target/hexagon) bug fixes for mem_noshuf

Taylor Simpson posted 2 patches 1 year, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220718224845.19878-1-tsimpson@quicinc.com
Maintainers: Taylor Simpson <tsimpson@quicinc.com>
There is a newer version of this series
target/hexagon/gen_tcg.h                 |  10 ++-
target/hexagon/helper.h                  |   1 +
target/hexagon/macros.h                  |  37 +++++---
target/hexagon/genptr.c                  |   7 ++
target/hexagon/op_helper.c               |  23 +++--
tests/tcg/hexagon/mem_noshuf.c           | 122 ++++++++++++++++++++++++--
tests/tcg/hexagon/mem_noshuf_exception.c | 146 +++++++++++++++++++++++++++++++
tests/tcg/hexagon/Makefile.target        |   1 +
8 files changed, 323 insertions(+), 24 deletions(-)
create mode 100644 tests/tcg/hexagon/mem_noshuf_exception.c
[PULL 0/2] Hexagon (target/hexagon) bug fixes for mem_noshuf
Posted by Taylor Simpson 1 year, 10 months ago
The following changes since commit 24f01d220f56eab3268538ef10655b4fb2453fdf:

  Merge https://github.com/qemu/qemu into tip (2022-07-18 11:16:39 -0700)

are available in the Git repository at:

  https://github.com/quic/qemu tags/pull-hex-20220718

for you to fetch changes up to eb9072602617cb49c489aaf058f72695c2eaedc2:

  Hexagon (target/hexagon) fix bug in mem_noshuf load exception (2022-07-18 11:20:09 -0700)

----------------------------------------------------------------
Recall that the semantics of a Hexagon mem_noshuf packet are that the
store effectively happens before the load.  There are two bug fixes
in this series.

----------------------------------------------------------------
Taylor Simpson (2):
      Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load
      Hexagon (target/hexagon) fix bug in mem_noshuf load exception

 target/hexagon/gen_tcg.h                 |  10 ++-
 target/hexagon/helper.h                  |   1 +
 target/hexagon/macros.h                  |  37 +++++---
 target/hexagon/genptr.c                  |   7 ++
 target/hexagon/op_helper.c               |  23 +++--
 tests/tcg/hexagon/mem_noshuf.c           | 122 ++++++++++++++++++++++++--
 tests/tcg/hexagon/mem_noshuf_exception.c | 146 +++++++++++++++++++++++++++++++
 tests/tcg/hexagon/Makefile.target        |   1 +
 8 files changed, 323 insertions(+), 24 deletions(-)
 create mode 100644 tests/tcg/hexagon/mem_noshuf_exception.c
Re: [PULL 0/2] Hexagon (target/hexagon) bug fixes for mem_noshuf
Posted by Peter Maydell 1 year, 10 months ago
On Mon, 18 Jul 2022 at 23:49, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> The following changes since commit 24f01d220f56eab3268538ef10655b4fb2453fdf:
>
>   Merge https://github.com/qemu/qemu into tip (2022-07-18 11:16:39 -0700)
>
> are available in the Git repository at:
>
>   https://github.com/quic/qemu tags/pull-hex-20220718
>
> for you to fetch changes up to eb9072602617cb49c489aaf058f72695c2eaedc2:

This tag is badly broken as a pull request, because it includes
this commit:

commit 24f01d220f56eab3268538ef10655b4fb2453fdf
Merge: eadad54bf10 78237897312
Author: Taylor Simpson <tsimpson@quicinc.com>
Date:   Mon Jul 18 11:16:39 2022 -0700

    Merge https://github.com/qemu/qemu into tip


Never merge upstream qemu back into a branch you're using
as a pull request, please. Just rebase the patches on
latest master.

Luckily I noticed in this case because it introduces
a whole load of garbage changes and doesn't build.

thanks
-- PMM
RE: [PULL 0/2] Hexagon (target/hexagon) bug fixes for mem_noshuf
Posted by Taylor Simpson 1 year, 10 months ago

> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Tuesday, July 19, 2022 6:05 AM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> f4bug@amsat.org
> Subject: Re: [PULL 0/2] Hexagon (target/hexagon) bug fixes for mem_noshuf
> 
> On Mon, 18 Jul 2022 at 23:49, Taylor Simpson <tsimpson@quicinc.com>
> wrote:
> >
> > The following changes since commit
> 24f01d220f56eab3268538ef10655b4fb2453fdf:
> >
> >   Merge https://github.com/qemu/qemu into tip (2022-07-18 11:16:39
> > -0700)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/quic/qemu tags/pull-hex-20220718
> >
> > for you to fetch changes up to
> eb9072602617cb49c489aaf058f72695c2eaedc2:
> 
> This tag is badly broken as a pull request, because it includes this commit:
> 
> commit 24f01d220f56eab3268538ef10655b4fb2453fdf
> Merge: eadad54bf10 78237897312
> Author: Taylor Simpson <tsimpson@quicinc.com>
> Date:   Mon Jul 18 11:16:39 2022 -0700
> 
>     Merge https://github.com/qemu/qemu into tip
> 
> 
> Never merge upstream qemu back into a branch you're using as a pull
> request, please. Just rebase the patches on latest master.
> 
> Luckily I noticed in this case because it introduces a whole load of garbage
> changes and doesn't build.
> 
> thanks
> -- PMM

My apologies.  I'll fix this and resubmit.

Taylor