[v2] target/s390x: vfmin/vfmax fixes

[PATCH v2 0/3] target/s390x: vfmin/vfmax fixes

Ilya Leoshkevich posted 3 patches 1 year, 10 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220713182612.3780050-1-iii@linux.ibm.com

Maintainers: Aurelien Jarno <aurelien@aurel32.net>, Peter Maydell <peter.maydell@linaro.org>, "Alex Bennée" <alex.bennee@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>

fpu/softfloat-specialize.c.inc    |   3 +-
target/s390x/tcg/vec_fpu_helper.c |   4 +-
tests/tcg/s390x/Makefile.target   |   7 +
tests/tcg/s390x/vfminmax.c        | 411 ++++++++++++++++++++++++++++++
4 files changed, 422 insertions(+), 3 deletions(-)
create mode 100644 tests/tcg/s390x/vfminmax.c

Expand all Fold all

[PATCH v2 0/3] target/s390x: vfmin/vfmax fixes

Posted by Ilya Leoshkevich 1 year, 10 months ago

Hi,

Uli has found an issue with finding maximum of different kinds of 0s; I
wrote a test and found another one with finding maximum of different
kinds of NaNs.

Patches 1 and 2 fix those issues, patch 3 adds a vfmin/vfmax test.

Best regards,
Ilya

v1: https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg01915.html
v1 -> v2: Drop mmap() in the test (Richard).

Ilya Leoshkevich (3):
  target/s390x: fix handling of zeroes in vfmin/vfmax
  target/s390x: fix NaN propagation rules
  tests/tcg/s390x: test signed vfmin/vfmax

 fpu/softfloat-specialize.c.inc    |   3 +-
 target/s390x/tcg/vec_fpu_helper.c |   4 +-
 tests/tcg/s390x/Makefile.target   |   7 +
 tests/tcg/s390x/vfminmax.c        | 411 ++++++++++++++++++++++++++++++
 4 files changed, 422 insertions(+), 3 deletions(-)
 create mode 100644 tests/tcg/s390x/vfminmax.c

-- 
2.35.3

Re: [PATCH v2 0/3] target/s390x: vfmin/vfmax fixes

Posted by Thomas Huth 1 year, 10 months ago

On 13/07/2022 20.26, Ilya Leoshkevich wrote:
> Hi,
> 
> Uli has found an issue with finding maximum of different kinds of 0s; I
> wrote a test and found another one with finding maximum of different
> kinds of NaNs.
> 
> Patches 1 and 2 fix those issues, patch 3 adds a vfmin/vfmax test.
> 
> Best regards,
> Ilya
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg01915.html
> v1 -> v2: Drop mmap() in the test (Richard).
> 
> Ilya Leoshkevich (3):
>    target/s390x: fix handling of zeroes in vfmin/vfmax
>    target/s390x: fix NaN propagation rules
>    tests/tcg/s390x: test signed vfmin/vfmax
> 
>   fpu/softfloat-specialize.c.inc    |   3 +-
>   target/s390x/tcg/vec_fpu_helper.c |   4 +-
>   tests/tcg/s390x/Makefile.target   |   7 +
>   tests/tcg/s390x/vfminmax.c        | 411 ++++++++++++++++++++++++++++++
>   4 files changed, 422 insertions(+), 3 deletions(-)
>   create mode 100644 tests/tcg/s390x/vfminmax.c
> 

Thanks, queued to my s390x-next branch now:

  https://gitlab.com/thuth/qemu/-/commits/s390x-next/

  Thomas