iotests/copy-before-write: specify required_fmts

[PATCH] iotests/copy-before-write: specify required_fmts

Posted by Vladimir Sementsov-Ogievskiy 1 year, 10 months ago

Declare that we need copy-before-write filter to avoid failure when
filter is not whitelisted.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
 tests/qemu-iotests/tests/copy-before-write | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/tests/copy-before-write b/tests/qemu-iotests/tests/copy-before-write
index 56937b9dff..2ffe092b31 100755
--- a/tests/qemu-iotests/tests/copy-before-write
+++ b/tests/qemu-iotests/tests/copy-before-write
@@ -218,4 +218,5 @@ read failed: Permission denied
 
 if __name__ == '__main__':
     iotests.main(supported_fmts=['qcow2'],
-                 supported_protocols=['file'])
+                 supported_protocols=['file'],
+                 required_fmts=['copy-before-write'])
-- 
2.25.1

Re: [PATCH] iotests/copy-before-write: specify required_fmts

Posted by Richard Henderson 1 year, 10 months ago

On 7/6/22 22:38, Vladimir Sementsov-Ogievskiy wrote:
> Declare that we need copy-before-write filter to avoid failure when
> filter is not whitelisted.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>   tests/qemu-iotests/tests/copy-before-write | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/tests/copy-before-write b/tests/qemu-iotests/tests/copy-before-write
> index 56937b9dff..2ffe092b31 100755
> --- a/tests/qemu-iotests/tests/copy-before-write
> +++ b/tests/qemu-iotests/tests/copy-before-write
> @@ -218,4 +218,5 @@ read failed: Permission denied
>   
>   if __name__ == '__main__':
>       iotests.main(supported_fmts=['qcow2'],
> -                 supported_protocols=['file'])
> +                 supported_protocols=['file'],
> +                 required_fmts=['copy-before-write'])


I am going to apply this as a hot fix, trying to re-green the CI.


r~

Re: [PATCH] iotests/copy-before-write: specify required_fmts

Posted by Thomas Huth 1 year, 10 months ago

On 06/07/2022 19.08, Vladimir Sementsov-Ogievskiy wrote:
> Declare that we need copy-before-write filter to avoid failure when
> filter is not whitelisted.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>   tests/qemu-iotests/tests/copy-before-write | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/tests/copy-before-write b/tests/qemu-iotests/tests/copy-before-write
> index 56937b9dff..2ffe092b31 100755
> --- a/tests/qemu-iotests/tests/copy-before-write
> +++ b/tests/qemu-iotests/tests/copy-before-write
> @@ -218,4 +218,5 @@ read failed: Permission denied
>   
>   if __name__ == '__main__':
>       iotests.main(supported_fmts=['qcow2'],
> -                 supported_protocols=['file'])
> +                 supported_protocols=['file'],
> +                 required_fmts=['copy-before-write'])

Thanks, that fixes the issue for me!

Tested-by: Thomas Huth <thuth@redhat.com>