[v1] ui/cocoa: Run qemu_init in the main thread

[PATCH 0/3] ui/cocoa: Run qemu_init in the main thread

Akihiko Odaki posted 3 patches 1 year, 10 months ago

Diff against v2 v3 v4 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220706021322.22570-1-akihiko.odaki@gmail.com

Maintainers: Alexander Bulekov <alxndr@bu.edu>, Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Thomas Huth <thuth@redhat.com>, Darren Kenny <darren.kenny@oracle.com>, Qiuhao Li <Qiuhao.Li@outlook.com>, Laurent Vivier <lvivier@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Akihiko Odaki <akihiko.odaki@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>

There is a newer version of this series

docs/devel/fuzzing.rst   |   4 +-
include/qemu-main.h      |   3 +-
include/qemu/main-loop.h |  13 ---
include/sysemu/sysemu.h  |   2 +-
meson.build              |  10 +--
softmmu/main.c           |  14 +--
softmmu/vl.c             |   2 +-
tests/qtest/fuzz/fuzz.c  |   2 +-
ui/cocoa.m               | 185 ++++++++++++---------------------------
9 files changed, 71 insertions(+), 164 deletions(-)

Expand all Fold all

[PATCH 0/3] ui/cocoa: Run qemu_init in the main thread

Posted by Akihiko Odaki 1 year, 10 months ago

This work is based on:
https://patchew.org/QEMU/20220317125534.38706-1-philippe.mathieu.daude@gmail.com/

Simplify the initialization dance by running qemu_init() in the main
thread before the Cocoa event loop starts. The secondary thread only
runs only qemu_main_loop() and qemu_cleanup().

This fixes a case where addRemovableDevicesMenuItems() calls
qmp_query_block() while expecting the main thread to still hold
the BQL.

Overriding the code after calling qemu_init() is done by dynamically
replacing a function pointer variable, qemu_main when initializing
ui/cocoa, which unifies the static implementation of main() for
builds with ui/cocoa and ones without ui/cocoa.

Akihiko Odaki (3):
  ui/cocoa: Run qemu_init in the main thread
  Revert "main-loop: Disable block backend global state assertion on
    Cocoa"
  meson: Allow to enable gtk and sdl while cocoa is enabled

 docs/devel/fuzzing.rst   |   4 +-
 include/qemu-main.h      |   3 +-
 include/qemu/main-loop.h |  13 ---
 include/sysemu/sysemu.h  |   2 +-
 meson.build              |  10 +--
 softmmu/main.c           |  14 +--
 softmmu/vl.c             |   2 +-
 tests/qtest/fuzz/fuzz.c  |   2 +-
 ui/cocoa.m               | 185 ++++++++++++---------------------------
 9 files changed, 71 insertions(+), 164 deletions(-)

-- 
2.32.1 (Apple Git-133)