There is nothing in this environment variable that cannot
be done better with -d flags.  There is nothing special
about TCI that warrants this hack.

Moreover, it does not compile -- remove it.

Reported-by: Song Gao <gaosong@loongson.cn>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/tci/tcg-target.h     | 5 -----
 tcg/tci/tcg-target.c.inc | 7 -------
 2 files changed, 12 deletions(-)

diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
index 033e613f24..ceb36c4f7a 100644
--- a/tcg/tci/tcg-target.h
+++ b/tcg/tci/tcg-target.h
@@ -53,11 +53,6 @@
 # error Unknown pointer size for tci target
 #endif
 
-#ifdef CONFIG_DEBUG_TCG
-/* Enable debug output. */
-#define CONFIG_DEBUG_TCG_INTERPRETER
-#endif
-
 /* Optional instructions. */
 
 #define TCG_TARGET_HAS_bswap16_i32      1
diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 98337c567a..f3d7441e06 100644
--- a/tcg/tci/tcg-target.c.inc
+++ b/tcg/tci/tcg-target.c.inc
@@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int count)
 
 static void tcg_target_init(TCGContext *s)
 {
-#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
-    const char *envval = getenv("DEBUG_TCG");
-    if (envval) {
-        qemu_set_log(strtol(envval, NULL, 0));
-    }
-#endif
-
     /* The current code uses uint8_t for tcg operations. */
     tcg_debug_assert(tcg_op_defs_max <= UINT8_MAX);
 
-- 
2.34.1

On 5/7/22 10:36, Richard Henderson wrote:
> There is nothing in this environment variable that cannot
> be done better with -d flags.  There is nothing special
> about TCI that warrants this hack.
> 
> Moreover, it does not compile -- remove it.
> 
> Reported-by: Song Gao <gaosong@loongson.cn>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/tci/tcg-target.h     | 5 -----
>   tcg/tci/tcg-target.c.inc | 7 -------
>   2 files changed, 12 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Richard Henderson <richard.henderson@linaro.org> writes:

> There is nothing in this environment variable that cannot
> be done better with -d flags.  There is nothing special
> about TCI that warrants this hack.
>
> Moreover, it does not compile -- remove it.
>
> Reported-by: Song Gao <gaosong@loongson.cn>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée

On 2022/7/5 下午4:36, Richard Henderson wrote:
> There is nothing in this environment variable that cannot
> be done better with -d flags.  There is nothing special
> about TCI that warrants this hack.
>
> Moreover, it does not compile -- remove it.
>
> Reported-by: Song Gao <gaosong@loongson.cn>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---

Reviewed-by: Song Gao <gaosong@loongson.cn>

>   tcg/tci/tcg-target.h     | 5 -----
>   tcg/tci/tcg-target.c.inc | 7 -------
>   2 files changed, 12 deletions(-)
>
> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
> index 033e613f24..ceb36c4f7a 100644
> --- a/tcg/tci/tcg-target.h
> +++ b/tcg/tci/tcg-target.h
> @@ -53,11 +53,6 @@
>   # error Unknown pointer size for tci target
>   #endif
>   
> -#ifdef CONFIG_DEBUG_TCG
> -/* Enable debug output. */
> -#define CONFIG_DEBUG_TCG_INTERPRETER
> -#endif
> -
>   /* Optional instructions. */
>   
>   #define TCG_TARGET_HAS_bswap16_i32      1
> diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
> index 98337c567a..f3d7441e06 100644
> --- a/tcg/tci/tcg-target.c.inc
> +++ b/tcg/tci/tcg-target.c.inc
> @@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int count)
>   
>   static void tcg_target_init(TCGContext *s)
>   {
> -#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
> -    const char *envval = getenv("DEBUG_TCG");
> -    if (envval) {
> -        qemu_set_log(strtol(envval, NULL, 0));
> -    }
> -#endif
> -
>       /* The current code uses uint8_t for tcg operations. */
>       tcg_debug_assert(tcg_op_defs_max <= UINT8_MAX);
>