stubs: update replay-tools to match replay.h types

[PATCH] stubs: update replay-tools to match replay.h types

Posted by Claudio Fontana 3 years, 7 months ago

detected with GCC 13 [-Werror=enum-int-mismatch]

Solves Issue #1096.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Cc: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
---
 stubs/replay-tools.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/stubs/replay-tools.c b/stubs/replay-tools.c
index 43296b3d4e..f2e72bb225 100644
--- a/stubs/replay-tools.c
+++ b/stubs/replay-tools.c
@@ -7,13 +7,14 @@ bool replay_events_enabled(void)
     return false;
 }
 
-int64_t replay_save_clock(unsigned int kind, int64_t clock, int64_t raw_icount)
+int64_t replay_save_clock(ReplayClockKind kind,
+                          int64_t clock, int64_t raw_icount)
 {
     abort();
     return 0;
 }
 
-int64_t replay_read_clock(unsigned int kind, int64_t raw_icount)
+int64_t replay_read_clock(ReplayClockKind kind, int64_t raw_icount)
 {
     abort();
     return 0;
@@ -48,11 +49,11 @@ void replay_mutex_unlock(void)
 {
 }
 
-void replay_register_char_driver(Chardev *chr)
+void replay_register_char_driver(struct Chardev *chr)
 {
 }
 
-void replay_chr_be_write(Chardev *s, uint8_t *buf, int len)
+void replay_chr_be_write(struct Chardev *s, uint8_t *buf, int len)
 {
     abort();
 }
-- 
2.26.2

Re: [PATCH] stubs: update replay-tools to match replay.h types

Posted by Paolo Bonzini 3 years, 6 months ago

Queued, thanks.

Paolo

Re: [PATCH] stubs: update replay-tools to match replay.h types

Posted by Thomas Huth 3 years, 7 months ago

On 04/07/2022 09.58, Claudio Fontana wrote:
> detected with GCC 13 [-Werror=enum-int-mismatch]
> 
> Solves Issue #1096.
> 
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Cc: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> ---
>   stubs/replay-tools.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/stubs/replay-tools.c b/stubs/replay-tools.c
> index 43296b3d4e..f2e72bb225 100644
> --- a/stubs/replay-tools.c
> +++ b/stubs/replay-tools.c
> @@ -7,13 +7,14 @@ bool replay_events_enabled(void)
>       return false;
>   }
>   
> -int64_t replay_save_clock(unsigned int kind, int64_t clock, int64_t raw_icount)
> +int64_t replay_save_clock(ReplayClockKind kind,
> +                          int64_t clock, int64_t raw_icount)
>   {
>       abort();
>       return 0;
>   }
>   
> -int64_t replay_read_clock(unsigned int kind, int64_t raw_icount)
> +int64_t replay_read_clock(ReplayClockKind kind, int64_t raw_icount)
>   {
>       abort();
>       return 0;
> @@ -48,11 +49,11 @@ void replay_mutex_unlock(void)
>   {
>   }
>   
> -void replay_register_char_driver(Chardev *chr)
> +void replay_register_char_driver(struct Chardev *chr)
>   {
>   }
>   
> -void replay_chr_be_write(Chardev *s, uint8_t *buf, int len)
> +void replay_chr_be_write(struct Chardev *s, uint8_t *buf, int len)
>   {
>       abort();
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>