Decouple Xen-HVM from PIIX

[PATCH 0/2] Decouple Xen-HVM from PIIX

Bernhard Beschow posted 2 patches 3 years, 7 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220626094656.15673-1-shentey@gmail.com

Maintainers: Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

hw/i386/xen/xen-hvm.c       | 17 ++---------------
hw/isa/piix3.c              | 15 ++++++++++++++-
include/hw/xen/xen.h        |  2 +-
include/hw/xen/xen_common.h |  6 ------
stubs/xen-hw-stub.c         |  3 ++-
5 files changed, 19 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH 0/2] Decouple Xen-HVM from PIIX

Posted by Bernhard Beschow 3 years, 7 months ago

hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in PIIX itself.

Bernhard Beschow (2):
  hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route()
  hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and
    remove it

 hw/i386/xen/xen-hvm.c       | 17 ++---------------
 hw/isa/piix3.c              | 15 ++++++++++++++-
 include/hw/xen/xen.h        |  2 +-
 include/hw/xen/xen_common.h |  6 ------
 stubs/xen-hw-stub.c         |  3 ++-
 5 files changed, 19 insertions(+), 24 deletions(-)

-- 
2.36.1

Re: [PATCH 0/2] Decouple Xen-HVM from PIIX

Posted by B 3 years, 7 months ago


Am 26. Juni 2022 09:46:54 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in PIIX itself.
>
>
>
>Bernhard Beschow (2):
>
>  hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route()
>
>  hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and
>
>    remove it
>
>
>
> hw/i386/xen/xen-hvm.c       | 17 ++---------------
>
> hw/isa/piix3.c              | 15 ++++++++++++++-
>
> include/hw/xen/xen.h        |  2 +-
>
> include/hw/xen/xen_common.h |  6 ------
>
> stubs/xen-hw-stub.c         |  3 ++-
>
> 5 files changed, 19 insertions(+), 24 deletions(-)
>
>
>
>-- >
>2.36.1
>
>
>

Hi Laurent,

would you like to queue this as well? Both patches have been reviewed at least once, piix twice. Or would you rather keep the review period open for longer?

Best regards,
Bernhard

Re: [PATCH 0/2] Decouple Xen-HVM from PIIX

Posted by Stefano Stabellini 3 years, 7 months ago

On Tue, 28 Jun 2022, B wrote:
> Am 26. Juni 2022 09:46:54 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> >hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in PIIX itself.
> >
> >
> >
> >Bernhard Beschow (2):
> >
> >  hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route()
> >
> >  hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and
> >
> >    remove it
> >
> >
> >
> > hw/i386/xen/xen-hvm.c       | 17 ++---------------
> >
> > hw/isa/piix3.c              | 15 ++++++++++++++-
> >
> > include/hw/xen/xen.h        |  2 +-
> >
> > include/hw/xen/xen_common.h |  6 ------
> >
> > stubs/xen-hw-stub.c         |  3 ++-
> >
> > 5 files changed, 19 insertions(+), 24 deletions(-)
> >
> >
> >
> >-- >
> >2.36.1
> >
> >
> >
> 
> Hi Laurent,
> 
> would you like to queue this as well? Both patches have been reviewed at least once, piix twice. Or would you rather keep the review period open for longer?
 
Paul reviewed them both -- I don't think we need further reviews.
Laurent could just take them.