According to https://gitlab.com/qemu-project/qemu/-/issues/1080#note_998088246
QEMU does not compile with older versions of libpng, so we should check
for a good version in meson.build. According to repology.org, our supported
host target operating systems ship these versions:

             Fedora 35: 1.6.37
     CentOS 8 (RHEL-8): 1.6.34
             Debian 11: 1.6.37
    OpenSUSE Leap 15.3: 1.6.34
      Ubuntu LTS 20.04: 1.6.37
         FreeBSD Ports: 1.6.37
         NetBSD pkgsrc: 1.6.37
         OpenBSD Ports: 1.6.37
              Homebrew: 1.6.37
           MSYS2 mingw: 1.6.37

So it seem reasonable to require at least libpng version 1.6.34 for
our builds.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1080
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 094c4ce832..164ecb2fab 100644
--- a/meson.build
+++ b/meson.build
@@ -1209,7 +1209,7 @@ if gtkx11.found()
 endif
 png = not_found
 if get_option('png').allowed() and have_system
-   png = dependency('libpng', required: get_option('png'),
+   png = dependency('libpng', version: '>=1.6.34', required: get_option('png'),
                     method: 'pkg-config', kwargs: static_kwargs)
 endif
 vnc = not_found
-- 
2.31.1

Queued, thanks.

Paolo

On 6/23/22 10:49, Thomas Huth wrote:
> According to https://gitlab.com/qemu-project/qemu/-/issues/1080#note_998088246
> QEMU does not compile with older versions of libpng, so we should check
> for a good version in meson.build. According to repology.org, our supported
> host target operating systems ship these versions:
> 
>               Fedora 35: 1.6.37
>       CentOS 8 (RHEL-8): 1.6.34
>               Debian 11: 1.6.37
>      OpenSUSE Leap 15.3: 1.6.34
>        Ubuntu LTS 20.04: 1.6.37
>           FreeBSD Ports: 1.6.37
>           NetBSD pkgsrc: 1.6.37
>           OpenBSD Ports: 1.6.37
>                Homebrew: 1.6.37
>             MSYS2 mingw: 1.6.37
> 
> So it seem reasonable to require at least libpng version 1.6.34 for
> our builds.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1080
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~