[v2] semihosting: proper QEMU exit on semihosted exit syscall

[PATCH v2 3/7] semihosting/arm-compat-semi: use semihosting_exit_request

Luc Michel posted 7 patches 3 years, 7 months ago

Diff against v1
Download mbox

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <laurent@vivier.eu>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Chris Wulff <crwulff@gmail.com>, Marek Vasut <marex@denx.de>, Max Filippov <jcmvbkbc@gmail.com>

Expand all Fold all

[PATCH v2 3/7] semihosting/arm-compat-semi: use semihosting_exit_request

Posted by Luc Michel 3 years, 7 months ago

Use the new semihosting_exit_request instead of a call to exit when
handling a semihosted exit syscall.

Signed-off-by: Luc Michel <lmichel@kalray.eu>
---
 semihosting/arm-compat-semi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index b6ddaf863a..fad5116f3c 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -1253,12 +1253,11 @@ target_ulong do_common_semihosting(CPUState *cs)
              * allow the guest to specify the exit status code.
              * Everything else is considered an error.
              */
             ret = (args == ADP_Stopped_ApplicationExit) ? 0 : 1;
         }
-        gdb_exit(ret);
-        exit(ret);
+        semihosting_exit_request(ret);
     case TARGET_SYS_ELAPSED:
         elapsed = get_clock() - clock_start;
         if (sizeof(target_ulong) == 8) {
             SET_ARG(0, elapsed);
         } else {
-- 
2.17.1

Re: [PATCH v2 3/7] semihosting/arm-compat-semi: use semihosting_exit_request

Posted by Laurent Vivier 3 years, 7 months ago

Le 21/06/2022 à 14:59, Luc Michel a écrit :
> Use the new semihosting_exit_request instead of a call to exit when
> handling a semihosted exit syscall.
> 
> Signed-off-by: Luc Michel <lmichel@kalray.eu>
> ---
>   semihosting/arm-compat-semi.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

[PATCH v2 1/7] softmmu: add qemu_[set|get]_exit_status functions
[PATCH v2 2/7] semihosting: add the semihosting_exit_request function
[PATCH v2 3/7] semihosting/arm-compat-semi: use semihosting_exit_request
[PATCH v2 4/7] target/m68k: use semihosting_exit_request on semihosted exit syscall
[PATCH v2 5/7] target/mips: use semihosting_exit_request on semihosted exit syscall
[PATCH v2 6/7] target/nios2: use semihosting_exit_request on semihosted exit syscall
[PATCH v2 7/7] target/xtensa: use semihosting_exit_request on semihosted exit syscall