1. Patchew
  2. QEMU
  3. [PATCH v7 0/6] cutils: Introduce bundle mechanism
  4. View patch

[PATCH v7 1/6] qga: Relocate a path emitted in the help text

Akihiko Odaki posted 6 patches 3 years, 7 months ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Jason Wang <jasowang@redhat.com>, Michael Roth <michael.roth@amd.com>, Alexander Bulekov <alxndr@bu.edu>, Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Darren Kenny <darren.kenny@oracle.com>, Qiuhao Li <Qiuhao.Li@outlook.com>, Laurent Vivier <lvivier@redhat.com>, Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, Ed Maste <emaste@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, Peter Maydell <peter.maydell@linaro.org>, Akihiko Odaki <akihiko.odaki@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>
There is a newer version of this series
[PATCH v7 1/6] qga: Relocate a path emitted in the help text
Posted by Akihiko Odaki 3 years, 7 months ago 
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
 qga/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/main.c b/qga/main.c
index c373fec3ee6..06e507b9979 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -270,7 +270,7 @@ QEMU_HELP_BOTTOM "\n"
     , cmd, QGA_VIRTIO_PATH_DEFAULT, QGA_SERIAL_PATH_DEFAULT,
     dfl_pathnames.pidfile,
 #ifdef CONFIG_FSFREEZE
-    QGA_FSFREEZE_HOOK_DEFAULT,
+    get_relocated_path(QGA_FSFREEZE_HOOK_DEFAULT),
 #endif
     dfl_pathnames.state_dir);
 }
-- 
2.32.1 (Apple Git-133)
Re: [PATCH v7 1/6] qga: Relocate a path emitted in the help text
Posted by Marc-André Lureau 3 years, 7 months ago 
On Wed, Jun 15, 2022 at 9:43 PM Akihiko Odaki <akihiko.odaki@gmail.com>
wrote:

> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  qga/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index c373fec3ee6..06e507b9979 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -270,7 +270,7 @@ QEMU_HELP_BOTTOM "\n"
>      , cmd, QGA_VIRTIO_PATH_DEFAULT, QGA_SERIAL_PATH_DEFAULT,
>      dfl_pathnames.pidfile,
>  #ifdef CONFIG_FSFREEZE
> -    QGA_FSFREEZE_HOOK_DEFAULT,
> +    get_relocated_path(QGA_FSFREEZE_HOOK_DEFAULT),
>  #endif
>      dfl_pathnames.state_dir);
>  }
> --
> 2.32.1 (Apple Git-133)
>
>
>

-- 
Marc-André Lureau
Re: [PATCH v7 1/6] qga: Relocate a path emitted in the help text
Posted by Marc-André Lureau 3 years, 7 months ago 
Hi

On Mon, Jun 20, 2022 at 5:11 PM Marc-André Lureau <
marcandre.lureau@gmail.com> wrote:

>
>
> On Wed, Jun 15, 2022 at 9:43 PM Akihiko Odaki <akihiko.odaki@gmail.com>
> wrote:
>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
>>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>

Oops, could you avoid leaking the result? g_autofree makes that easy.
thanks


> ---
>>  qga/main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qga/main.c b/qga/main.c
>> index c373fec3ee6..06e507b9979 100644
>> --- a/qga/main.c
>> +++ b/qga/main.c
>> @@ -270,7 +270,7 @@ QEMU_HELP_BOTTOM "\n"
>>      , cmd, QGA_VIRTIO_PATH_DEFAULT, QGA_SERIAL_PATH_DEFAULT,
>>      dfl_pathnames.pidfile,
>>  #ifdef CONFIG_FSFREEZE
>> -    QGA_FSFREEZE_HOOK_DEFAULT,
>> +    get_relocated_path(QGA_FSFREEZE_HOOK_DEFAULT),
>>  #endif
>>      dfl_pathnames.state_dir);
>>  }
>> --
>> 2.32.1 (Apple Git-133)
>>
>>
>>
>
> --
> Marc-André Lureau
>


-- 
Marc-André Lureau
Re: [PATCH v7 1/6] qga: Relocate a path emitted in the help text
Posted by Konstantin Kostiuk 3 years, 7 months ago 
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>


On Wed, Jun 15, 2022 at 8:43 PM Akihiko Odaki <akihiko.odaki@gmail.com>
wrote:

> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>  qga/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index c373fec3ee6..06e507b9979 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -270,7 +270,7 @@ QEMU_HELP_BOTTOM "\n"
>      , cmd, QGA_VIRTIO_PATH_DEFAULT, QGA_SERIAL_PATH_DEFAULT,
>      dfl_pathnames.pidfile,
>  #ifdef CONFIG_FSFREEZE
> -    QGA_FSFREEZE_HOOK_DEFAULT,
> +    get_relocated_path(QGA_FSFREEZE_HOOK_DEFAULT),
>  #endif
>      dfl_pathnames.state_dir);
>  }
> --
> 2.32.1 (Apple Git-133)
>
>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.