[PATCH 3/7] crypto: remove "qemu/osdep.h" in rsakey.h

Lei He posted 7 patches 3 years, 8 months ago
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>
There is a newer version of this series
[PATCH 3/7] crypto: remove "qemu/osdep.h" in rsakey.h
Posted by Lei He 3 years, 8 months ago
Move 'include "qemu/osdep.h"' from rsakey.h to rsakey.c.

Signed-off-by: lei he <helei.sig11@bytedance.com>
---
 crypto/rsakey.c | 1 +
 crypto/rsakey.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/rsakey.c b/crypto/rsakey.c
index cc40e072f0..dcdbd9ec57 100644
--- a/crypto/rsakey.c
+++ b/crypto/rsakey.c
@@ -19,6 +19,7 @@
  *
  */
 
+#include "qemu/osdep.h"
 #include "rsakey.h"
 
 void qcrypto_akcipher_rsakey_free(QCryptoAkCipherRSAKey *rsa_key)
diff --git a/crypto/rsakey.h b/crypto/rsakey.h
index 974b76f659..ba88974d12 100644
--- a/crypto/rsakey.h
+++ b/crypto/rsakey.h
@@ -22,7 +22,6 @@
 #ifndef QCRYPTO_RSAKEY_H
 #define QCRYPTO_RSAKEY_H
 
-#include "qemu/osdep.h"
 #include "qemu/host-utils.h"
 #include "crypto/akcipher.h"
 
-- 
2.11.0
Re: [PATCH 3/7] crypto: remove "qemu/osdep.h" in rsakey.h
Posted by Daniel P. Berrangé 3 years, 7 months ago
On Mon, Jun 13, 2022 at 04:45:27PM +0800, Lei He wrote:
> Move 'include "qemu/osdep.h"' from rsakey.h to rsakey.c.
> 
> Signed-off-by: lei he <helei.sig11@bytedance.com>
> ---
>  crypto/rsakey.c | 1 +
>  crypto/rsakey.h | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH 3/7] crypto: remove "qemu/osdep.h" in rsakey.h
Posted by Philippe Mathieu-Daudé via 3 years, 8 months ago
On 13/6/22 10:45, Lei He wrote:
> Move 'include "qemu/osdep.h"' from rsakey.h to rsakey.c.
> 
> Signed-off-by: lei he <helei.sig11@bytedance.com>
> ---
>   crypto/rsakey.c | 1 +
>   crypto/rsakey.h | 1 -
>   2 files changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>