tests/qtest: Reduce npcm7xx_sdhci test image size

[PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size

Hao Wu posted 1 patch 1 year, 11 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220609214125.4192212-1-wuhaotsh@google.com

Maintainers: Havard Skinnemoen <hskinnemoen@google.com>, Tyrone Ting <kfting@nuvoton.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/npcm7xx_sdhci-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size

Posted by Hao Wu 1 year, 11 months ago

Creating 1GB image for a simple qtest is unnecessary
and could lead to failures. We reduce the image size
to 1MB to reduce the test overhead.

Signed-off-by: Hao Wu <wuhaotsh@google.com>
---
 tests/qtest/npcm7xx_sdhci-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/npcm7xx_sdhci-test.c b/tests/qtest/npcm7xx_sdhci-test.c
index aa35a77e8d..5d68540e52 100644
--- a/tests/qtest/npcm7xx_sdhci-test.c
+++ b/tests/qtest/npcm7xx_sdhci-test.c
@@ -24,7 +24,7 @@
 #define NPCM7XX_REG_SIZE 0x100
 #define NPCM7XX_MMC_BA 0xF0842000
 #define NPCM7XX_BLK_SIZE 512
-#define NPCM7XX_TEST_IMAGE_SIZE (1 << 30)
+#define NPCM7XX_TEST_IMAGE_SIZE (1 << 20)
 
 char *sd_path;
 
-- 
2.36.1.476.g0c4daa206d-goog

Re: [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size

Posted by Philippe Mathieu-Daudé via 1 year, 11 months ago

On 9/6/22 23:41, Hao Wu wrote:
> Creating 1GB image for a simple qtest is unnecessary
> and could lead to failures. We reduce the image size
> to 1MB to reduce the test overhead.
> 
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
>   tests/qtest/npcm7xx_sdhci-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size

Posted by Peter Maydell 1 year, 11 months ago

On Thu, 9 Jun 2022 at 22:41, Hao Wu <wuhaotsh@google.com> wrote:
>
> Creating 1GB image for a simple qtest is unnecessary
> and could lead to failures. We reduce the image size
> to 1MB to reduce the test overhead.
>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
>  tests/qtest/npcm7xx_sdhci-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)



Applied to target-arm.next, thanks.

-- PMM