[PATCH untested] tests/tcg: disable xtensa-linux-user again

Paolo Bonzini posted 1 patch 3 years, 8 months ago
Failed in applying to current master (apply log)
configure | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[PATCH untested] tests/tcg: disable xtensa-linux-user again
Posted by Paolo Bonzini 3 years, 8 months ago
The move from tests/tcg/configure.sh started enabling the container image
for xtensa-linux-user, which fails because the compiler does not have
the full set of headers.  The cause is the "xtensa*-softmmu)" case
in tests/tcg/configure.sh which became just "xtensa*)" in the new
probe_target_compiler shell function.  Look out for xtensa*-linux-user
and do not configure it.

Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 7d021a4014..e9822ff56c 100755
--- a/configure
+++ b/configure
@@ -1923,7 +1923,6 @@ probe_target_compiler() {
         container_cross_prefix=x86_64-linux-gnu-
         ;;
       xtensa*)
-        # FIXME: xtensa-linux-user?
         container_hosts=x86_64
         container_image=debian-xtensa-cross
 
@@ -2352,6 +2351,10 @@ for target in $target_list; do
   probe_target_compiler ${arch}
 
   case $target in
+    xtensa*-linux-user)
+      # the toolchain is not complete with headers, only build softmmu tests
+      continue
+      ;;
     *-softmmu)
       test -f $source_path/tests/tcg/$arch/Makefile.softmmu-target || continue
       qemu="qemu-system-$arch"
-- 
2.36.1


Re: [PATCH untested] tests/tcg: disable xtensa-linux-user again
Posted by Alex Bennée 3 years, 8 months ago
Paolo Bonzini <pbonzini@redhat.com> writes:

> The move from tests/tcg/configure.sh started enabling the container image
> for xtensa-linux-user, which fails because the compiler does not have
> the full set of headers.  The cause is the "xtensa*-softmmu)" case
> in tests/tcg/configure.sh which became just "xtensa*)" in the new
> probe_target_compiler shell function.  Look out for xtensa*-linux-user
> and do not configure it.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Queued to testing/next, thanks.

-- 
Alex Bennée