On 8/6/22 07:19, Richard Henderson wrote:
> The function is no longer used.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/semihosting/console.h | 13 -------------
> semihosting/console.c | 9 ---------
> 2 files changed, 22 deletions(-)
>
> diff --git a/include/semihosting/console.h b/include/semihosting/console.h
> index 61b0cb3a94..bd78e5f03f 100644
> --- a/include/semihosting/console.h
> +++ b/include/semihosting/console.h
> @@ -40,19 +40,6 @@ int qemu_semihosting_console_read(CPUState *cs, void *buf, int len);
> */
> int qemu_semihosting_console_write(void *buf, int len);
>
> -/**
> - * qemu_semihosting_log_out:
> - * @s: pointer to string
> - * @len: length of string
> - *
> - * Send a string to the debug output. Unlike console_out these strings
> - * can't be sent to a remote gdb instance as they don't exist in guest
> - * memory.
> - *
> - * Returns: number of bytes written
> - */
> -int qemu_semihosting_log_out(const char *s, int len);
> -
> /*
> * qemu_semihosting_console_block_until_ready:
> * @cs: CPUState
> diff --git a/semihosting/console.c b/semihosting/console.c
> index cda7cf1905..5b1ec0a1c3 100644
> --- a/semihosting/console.c
> +++ b/semihosting/console.c
> @@ -38,15 +38,6 @@ typedef struct SemihostingConsole {
>
> static SemihostingConsole console;
>
> -int qemu_semihosting_log_out(const char *s, int len)
> -{
> - if (console.chr) {
> - return qemu_chr_write_all(console.chr, (uint8_t *) s, len);
> - } else {
> - return write(STDERR_FILENO, s, len);
> - }
> -}
> -
> #define FIFO_SIZE 1024
>
> static int console_can_read(void *opaque)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>