[v3] QOM improvements for rtc/mc146818rtc

[PATCH v3 0/3] QOM improvements for rtc/mc146818rtc

Bernhard Beschow posted 3 patches 1 year, 11 months ago

Diff against v1 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220529184006.10712-1-shentey@gmail.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>

There is a newer version of this series

hw/i386/microvm-dt.c         | 9 +++++----
hw/rtc/mc146818rtc.c         | 9 ++++++---
include/hw/rtc/mc146818rtc.h | 2 +-
3 files changed, 12 insertions(+), 8 deletions(-)

Expand all Fold all

[PATCH v3 0/3] QOM improvements for rtc/mc146818rtc

Posted by Bernhard Beschow 1 year, 11 months ago

v3:
* "iobase" is now u16 (Philippe)

v2:
* Explicitly fail with &error_abort rather than NULL (Mark)
* Explicitly fail with &error_abort rather than NULL in existing code (me)
* Unexport rather than remove RTC_ISA_BASE (Mark)
* Use object_property_get_*u*int() also for "iobase" (me)

v1:
This little series enhances QOM support for mc146818rtc:
* makes microvm-dt respect mc146818rtc's IRQ number set by QOM property and
* adds an io_base QOM property similar to other ISA devices

Bernhard Beschow (3):
  hw/i386/microvm-dt: Force explicit failure if retrieving QOM property
    fails
  hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM
    property
  rtc/mc146818rtc: QOM'ify io_base offset

 hw/i386/microvm-dt.c         | 9 +++++----
 hw/rtc/mc146818rtc.c         | 9 ++++++---
 include/hw/rtc/mc146818rtc.h | 2 +-
 3 files changed, 12 insertions(+), 8 deletions(-)

-- 
2.36.1

[PATCH v3 0/3] QOM improvements for rtc/mc146818rtc

Posted by Bernhard Beschow 1 year, 11 months ago

Ping

Am 29. Mai 2022 18:40:03 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>v3:
>* "iobase" is now u16 (Philippe)
>
>v2:
>* Explicitly fail with &error_abort rather than NULL (Mark)
>* Explicitly fail with &error_abort rather than NULL in existing code (me)
>* Unexport rather than remove RTC_ISA_BASE (Mark)
>* Use object_property_get_*u*int() also for "iobase" (me)
>
>v1:
>This little series enhances QOM support for mc146818rtc:
>* makes microvm-dt respect mc146818rtc's IRQ number set by QOM property and
>* adds an io_base QOM property similar to other ISA devices
>
>Bernhard Beschow (3):
>  hw/i386/microvm-dt: Force explicit failure if retrieving QOM property
>    fails
>  hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM
>    property
>  rtc/mc146818rtc: QOM'ify io_base offset
>
> hw/i386/microvm-dt.c         | 9 +++++----
> hw/rtc/mc146818rtc.c         | 9 ++++++---
> include/hw/rtc/mc146818rtc.h | 2 +-
> 3 files changed, 12 insertions(+), 8 deletions(-)
>

Ping

Re: [PATCH v3 0/3] QOM improvements for rtc/mc146818rtc

Posted by Philippe Mathieu-Daudé via 1 year, 10 months ago

On 2/6/22 23:18, Bernhard Beschow wrote:
> Ping
> 
> Am 29. Mai 2022 18:40:03 UTC schrieb Bernhard Beschow <shentey@gmail.com 
> <mailto:shentey@gmail.com>>:
>  >v3:
>  >* "iobase" is now u16 (Philippe)
>  >
>  >v2:
>  >* Explicitly fail with &error_abort rather than NULL (Mark)
>  >* Explicitly fail with &error_abort rather than NULL in existing code (me)
>  >* Unexport rather than remove RTC_ISA_BASE (Mark)
>  >* Use object_property_get_*u*int() also for "iobase" (me)
>  >
>  >v1:
>  >This little series enhances QOM support for mc146818rtc:
>  >* makes microvm-dt respect mc146818rtc's IRQ number set by QOM 
> property and
>  >* adds an io_base QOM property similar to other ISA devices
>  >
>  >Bernhard Beschow (3):
>  >  hw/i386/microvm-dt: Force explicit failure if retrieving QOM property
>  >    fails
>  >  hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM
>  >    property
>  >  rtc/mc146818rtc: QOM'ify io_base offset

Series queued via mips-next tree, thanks!