1. Patchew
  2. QEMU
  3. [PATCH 0/9] tests, python: prepare to expand usage of test venv
  4. View patch

[PATCH 8/9] tests: add python3-venv to debian10.docker

John Snow posted 9 patches 3 years, 8 months ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>
[PATCH 8/9] tests: add python3-venv to debian10.docker
Posted by John Snow 3 years, 8 months ago 
This is needed to be able to add a venv-building step to 'make check';
the clang-user job in particular needs this to be able to run
check-unit.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/docker/dockerfiles/debian10.docker | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
index b414af1b9f7..03be9230664 100644
--- a/tests/docker/dockerfiles/debian10.docker
+++ b/tests/docker/dockerfiles/debian10.docker
@@ -34,4 +34,5 @@ RUN apt update && \
         python3 \
         python3-sphinx \
         python3-sphinx-rtd-theme \
+        python3-venv \
         $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\  -f2)
-- 
2.34.1
Re: [PATCH 8/9] tests: add python3-venv to debian10.docker
Posted by Thomas Huth 3 years, 8 months ago 
On 26/05/2022 02.09, John Snow wrote:
> This is needed to be able to add a venv-building step to 'make check';
> the clang-user job in particular needs this to be able to run
> check-unit.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/docker/dockerfiles/debian10.docker | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
> index b414af1b9f7..03be9230664 100644
> --- a/tests/docker/dockerfiles/debian10.docker
> +++ b/tests/docker/dockerfiles/debian10.docker
> @@ -34,4 +34,5 @@ RUN apt update && \
>           python3 \
>           python3-sphinx \
>           python3-sphinx-rtd-theme \
> +        python3-venv \
>           $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\  -f2)

Note that we'll (hopefully) drop the debian 10 container soon, since Debian 
10 is EOL by the time we publish the next QEMU release.

  Thomas
Re: [PATCH 8/9] tests: add python3-venv to debian10.docker
Posted by John Snow 3 years, 8 months ago 
On Mon, May 30, 2022 at 3:33 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 26/05/2022 02.09, John Snow wrote:
> > This is needed to be able to add a venv-building step to 'make check';
> > the clang-user job in particular needs this to be able to run
> > check-unit.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   tests/docker/dockerfiles/debian10.docker | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
> > index b414af1b9f7..03be9230664 100644
> > --- a/tests/docker/dockerfiles/debian10.docker
> > +++ b/tests/docker/dockerfiles/debian10.docker
> > @@ -34,4 +34,5 @@ RUN apt update && \
> >           python3 \
> >           python3-sphinx \
> >           python3-sphinx-rtd-theme \
> > +        python3-venv \
> >           $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\  -f2)
>
> Note that we'll (hopefully) drop the debian 10 container soon, since Debian
> 10 is EOL by the time we publish the next QEMU release.
>

Noted -- do you think it'd be OK to sneak this change in first and
have you move the requisite to the new container? :)
Re: [PATCH 8/9] tests: add python3-venv to debian10.docker
Posted by Thomas Huth 3 years, 8 months ago 
On 31/05/2022 20.28, John Snow wrote:
> On Mon, May 30, 2022 at 3:33 AM Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 26/05/2022 02.09, John Snow wrote:
>>> This is needed to be able to add a venv-building step to 'make check';
>>> the clang-user job in particular needs this to be able to run
>>> check-unit.
>>>
>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>> ---
>>>    tests/docker/dockerfiles/debian10.docker | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
>>> index b414af1b9f7..03be9230664 100644
>>> --- a/tests/docker/dockerfiles/debian10.docker
>>> +++ b/tests/docker/dockerfiles/debian10.docker
>>> @@ -34,4 +34,5 @@ RUN apt update && \
>>>            python3 \
>>>            python3-sphinx \
>>>            python3-sphinx-rtd-theme \
>>> +        python3-venv \
>>>            $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\  -f2)
>>
>> Note that we'll (hopefully) drop the debian 10 container soon, since Debian
>> 10 is EOL by the time we publish the next QEMU release.
>>
> 
> Noted -- do you think it'd be OK to sneak this change in first and
> have you move the requisite to the new container? :)

I don't mind - whatever comes first ... I just wanted to make you aware that 
there might be conflicts ;-)

  Thomas
Re: [PATCH 8/9] tests: add python3-venv to debian10.docker
Posted by John Snow 3 years, 8 months ago 
On Wed, Jun 1, 2022, 3:29 AM Thomas Huth <thuth@redhat.com> wrote:

> On 31/05/2022 20.28, John Snow wrote:
> > On Mon, May 30, 2022 at 3:33 AM Thomas Huth <thuth@redhat.com> wrote:
> >>
> >> On 26/05/2022 02.09, John Snow wrote:
> >>> This is needed to be able to add a venv-building step to 'make check';
> >>> the clang-user job in particular needs this to be able to run
> >>> check-unit.
> >>>
> >>> Signed-off-by: John Snow <jsnow@redhat.com>
> >>> ---
> >>>    tests/docker/dockerfiles/debian10.docker | 1 +
> >>>    1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/tests/docker/dockerfiles/debian10.docker
> b/tests/docker/dockerfiles/debian10.docker
> >>> index b414af1b9f7..03be9230664 100644
> >>> --- a/tests/docker/dockerfiles/debian10.docker
> >>> +++ b/tests/docker/dockerfiles/debian10.docker
> >>> @@ -34,4 +34,5 @@ RUN apt update && \
> >>>            python3 \
> >>>            python3-sphinx \
> >>>            python3-sphinx-rtd-theme \
> >>> +        python3-venv \
> >>>            $(apt-get -s build-dep --arch-only qemu | egrep ^Inst |
> fgrep '[all]' | cut -d\  -f2)
> >>
> >> Note that we'll (hopefully) drop the debian 10 container soon, since
> Debian
> >> 10 is EOL by the time we publish the next QEMU release.
> >>
> >
> > Noted -- do you think it'd be OK to sneak this change in first and
> > have you move the requisite to the new container? :)
>
> I don't mind - whatever comes first ... I just wanted to make you aware
> that
> there might be conflicts ;-)
>
>   Thomas
>

Yep, got it! No problem at all. Thanks ~~

>
Re: [PATCH 8/9] tests: add python3-venv to debian10.docker
Posted by Paolo Bonzini 3 years, 8 months ago 
On 5/26/22 02:09, John Snow wrote:
> This is needed to be able to add a venv-building step to 'make check';
> the clang-user job in particular needs this to be able to run
> check-unit.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/docker/dockerfiles/debian10.docker | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
> index b414af1b9f7..03be9230664 100644
> --- a/tests/docker/dockerfiles/debian10.docker
> +++ b/tests/docker/dockerfiles/debian10.docker
> @@ -34,4 +34,5 @@ RUN apt update && \
>           python3 \
>           python3-sphinx \
>           python3-sphinx-rtd-theme \
> +        python3-venv \
>           $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\  -f2)

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.