.gitlab-ci.d/crossbuilds: Fix the dependency of the cross-i386-tci job

[PATCH] .gitlab-ci.d/crossbuilds: Fix the dependency of the cross-i386-tci job

Thomas Huth posted 1 patch 3 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220524092600.89997-1-thuth@redhat.com

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>

.gitlab-ci.d/crossbuilds.yml | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] .gitlab-ci.d/crossbuilds: Fix the dependency of the cross-i386-tci job

Posted by Thomas Huth 3 years, 8 months ago

The cross-i386-tci job uses the fedora-i386-cross image, so we should make sure
that the corresponding job that builds it (the i386-fedora-cross-container job)
has finished before we start the TCI job.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.d/crossbuilds.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
index 8f5add46ac..fe6bfacc30 100644
--- a/.gitlab-ci.d/crossbuilds.yml
+++ b/.gitlab-ci.d/crossbuilds.yml
@@ -63,6 +63,8 @@ cross-i386-user:
 cross-i386-tci:
   extends: .cross_accel_build_job
   timeout: 60m
+  needs:
+    job: i386-fedora-cross-container
   variables:
     IMAGE: fedora-i386-cross
     ACCEL: tcg-interpreter
-- 
2.27.0

Re: [PATCH] .gitlab-ci.d/crossbuilds: Fix the dependency of the cross-i386-tci job

Posted by Alex Bennée 3 years, 8 months ago

Thomas Huth <thuth@redhat.com> writes:

> The cross-i386-tci job uses the fedora-i386-cross image, so we should make sure
> that the corresponding job that builds it (the i386-fedora-cross-container job)
> has finished before we start the TCI job.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Queued to testing/next, thanks.

-- 
Alex Bennée

Re: [PATCH] .gitlab-ci.d/crossbuilds: Fix the dependency of the cross-i386-tci job

Posted by Richard Henderson 3 years, 8 months ago

On 5/24/22 02:26, Thomas Huth wrote:
> The cross-i386-tci job uses the fedora-i386-cross image, so we should make sure
> that the corresponding job that builds it (the i386-fedora-cross-container job)
> has finished before we start the TCI job.
> 
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
>   .gitlab-ci.d/crossbuilds.yml | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~