[v4] block/dirty-bitmaps: fix and improve bitmap merge

[PATCH v4 0/3] block/dirty-bitmaps: fix and improve bitmap merge

Vladimir Sementsov-Ogievskiy posted 3 patches 1 year, 11 months ago

Diff against v1 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220517111206.23585-1-v.sementsov-og@mail.ru

Maintainers: John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Eric Blake <eblake@redhat.com>

include/block/block_int-io.h    |  2 +-
include/qemu/hbitmap.h          | 15 ++-----------
block/backup.c                  |  6 ++---
block/dirty-bitmap.c            | 26 +++++++++------------
block/monitor/bitmap-qmp-cmds.c | 40 ++++++++++++++++++---------------
util/hbitmap.c                  | 25 ++++++---------------
6 files changed, 45 insertions(+), 69 deletions(-)

Expand all Fold all

[PATCH v4 0/3] block/dirty-bitmaps: fix and improve bitmap merge

Posted by Vladimir Sementsov-Ogievskiy 1 year, 11 months ago

From: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>

v4:
01,03: add Kevin's r-b
02: add hbitmap_free() on success patch if local_backup is not needed

Vladimir Sementsov-Ogievskiy (3):
  block: block_dirty_bitmap_merge(): fix error path
  block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap
  block: simplify handling of try to merge different sized bitmaps

 include/block/block_int-io.h    |  2 +-
 include/qemu/hbitmap.h          | 15 ++-----------
 block/backup.c                  |  6 ++---
 block/dirty-bitmap.c            | 26 +++++++++------------
 block/monitor/bitmap-qmp-cmds.c | 40 ++++++++++++++++++---------------
 util/hbitmap.c                  | 25 ++++++---------------
 6 files changed, 45 insertions(+), 69 deletions(-)

-- 
2.35.1

Re: [PATCH v4 0/3] block/dirty-bitmaps: fix and improve bitmap merge

Posted by Kevin Wolf 1 year, 11 months ago

Am 17.05.2022 um 13:12 hat Vladimir Sementsov-Ogievskiy geschrieben:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> 
> v4:
> 01,03: add Kevin's r-b
> 02: add hbitmap_free() on success patch if local_backup is not needed
> 
> Vladimir Sementsov-Ogievskiy (3):
>   block: block_dirty_bitmap_merge(): fix error path
>   block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap
>   block: simplify handling of try to merge different sized bitmaps

Thanks, applied to the block branch.

Kevin

Re: [PATCH v4 0/3] block/dirty-bitmaps: fix and improve bitmap merge

Posted by Eric Blake 1 year, 11 months ago

On Tue, May 17, 2022 at 02:12:03PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> 
> v4:
> 01,03: add Kevin's r-b
> 02: add hbitmap_free() on success patch if local_backup is not needed
> 
> Vladimir Sementsov-Ogievskiy (3):
>   block: block_dirty_bitmap_merge(): fix error path
>   block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap
>   block: simplify handling of try to merge different sized bitmaps

I plan to queue this through my block bitmaps tree, if no other block
maintainer beats me to it (I may do a combined pull request for that
and NBD patches).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org