hw/nvme: clear aen mask on reset

[PATCH] hw/nvme: clear aen mask on reset

Posted by Klaus Jensen 3 years, 9 months ago

From: Klaus Jensen <k.jensen@samsung.com>

The internally maintained AEN mask is not cleared on reset. Fix this.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/nvme/ctrl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 1e6e0fcad918..4c8200dfb859 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -5889,6 +5889,7 @@ static void nvme_ctrl_reset(NvmeCtrl *n)
     }
 
     n->aer_queued = 0;
+    n->aer_mask = 0;
     n->outstanding_aers = 0;
     n->qs_created = false;
 }
-- 
2.36.0

Re: [PATCH] hw/nvme: clear aen mask on reset

Posted by Klaus Jensen 3 years, 7 months ago

On May 12 11:30, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> The internally maintained AEN mask is not cleared on reset. Fix this.
> 
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>  hw/nvme/ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 1e6e0fcad918..4c8200dfb859 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
> @@ -5889,6 +5889,7 @@ static void nvme_ctrl_reset(NvmeCtrl *n)
>      }
>  
>      n->aer_queued = 0;
> +    n->aer_mask = 0;
>      n->outstanding_aers = 0;
>      n->qs_created = false;
>  }
> -- 
> 2.36.0
> 

Applied to nvme-next.

Re: [PATCH] hw/nvme: clear aen mask on reset

Posted by Keith Busch 3 years, 8 months ago

On Thu, May 12, 2022 at 11:30:55AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> The internally maintained AEN mask is not cleared on reset. Fix this.

Looks good.

Reviewed-by: Keith Busch <kbusch@kernel.org>

Re: [PATCH] hw/nvme: clear aen mask on reset

Posted by Klaus Jensen 3 years, 8 months ago

On May 12 11:30, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> The internally maintained AEN mask is not cleared on reset. Fix this.
> 
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>  hw/nvme/ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 1e6e0fcad918..4c8200dfb859 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
> @@ -5889,6 +5889,7 @@ static void nvme_ctrl_reset(NvmeCtrl *n)
>      }
>  
>      n->aer_queued = 0;
> +    n->aer_mask = 0;
>      n->outstanding_aers = 0;
>      n->qs_created = false;
>  }
> -- 
> 2.36.0
> 

Gentle bump.