usbredir: avoid queuing hello packet on snapshot restore

[PATCH] usbredir: avoid queuing hello packet on snapshot restore

Joelle van Dyne posted 1 patch 2 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220507041850.98716-1-j@getutm.app

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

hw/usb/redirect.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] usbredir: avoid queuing hello packet on snapshot restore

Posted by Joelle van Dyne 2 years ago

When launching QEMU with "-loadvm", usbredir_create_parser() should avoid
setting up the hello packet (just as with "-incoming". On the latest version
of libusbredir, usbredirparser_unserialize() will return error if the parser
is not "pristine."

Signed-off-by: Joelle van Dyne <j@getutm.app>
---
 hw/usb/redirect.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 3bc4dee7fe..f8bec9b292 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1280,7 +1280,8 @@ static void usbredir_create_parser(USBRedirDevice *dev)
     }
 #endif
 
-    if (runstate_check(RUN_STATE_INMIGRATE)) {
+    if (runstate_check(RUN_STATE_INMIGRATE) ||
+        runstate_check(RUN_STATE_PRELAUNCH)) {
         flags |= usbredirparser_fl_no_hello;
     }
     usbredirparser_init(dev->parser, VERSION, caps, USB_REDIR_CAPS_SIZE,
-- 
2.28.0

Re: [PATCH] usbredir: avoid queuing hello packet on snapshot restore

Posted by Gerd Hoffmann 1 year, 11 months ago

On Fri, May 06, 2022 at 09:18:50PM -0700, Joelle van Dyne wrote:
> When launching QEMU with "-loadvm", usbredir_create_parser() should avoid
> setting up the hello packet (just as with "-incoming". On the latest version
> of libusbredir, usbredirparser_unserialize() will return error if the parser
> is not "pristine."
> 
> Signed-off-by: Joelle van Dyne <j@getutm.app>

Patch queued up.

thanks,
  Gerd