target/mips: Fix FTRUNC_S and FTRUNC_U trans helper

[PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper

Posted by nihui 1 year, 12 months ago

Fix the FTRUNC_S and FTRUNC_U trans helper problem.

Signed-off-by: nihui <shuizhuyuanluo@126.com>
---
 target/mips/tcg/msa_translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c
index 0b3dd0957c..1bcdbb1121 100644
--- a/target/mips/tcg/msa_translate.c
+++ b/target/mips/tcg/msa_translate.c
@@ -752,8 +752,8 @@ static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a,
 }
 
 TRANS(FCLASS,   trans_msa_2rf, gen_helper_msa_fclass_df);
-TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_fclass_df);
-TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
+TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
+TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_u_df);
 TRANS(FSQRT,    trans_msa_2rf, gen_helper_msa_fsqrt_df);
 TRANS(FRSQRT,   trans_msa_2rf, gen_helper_msa_frsqrt_df);
 TRANS(FRCP,     trans_msa_2rf, gen_helper_msa_frcp_df);
-- 
2.25.1

Re: [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper

Posted by Philippe Mathieu-Daudé via 1 year, 11 months ago

On 3/5/22 16:42, nihui wrote:
> Fix the FTRUNC_S and FTRUNC_U trans helper problem.
> 
> Signed-off-by: nihui <shuizhuyuanluo@126.com>
> ---
>   target/mips/tcg/msa_translate.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c
> index 0b3dd0957c..1bcdbb1121 100644
> --- a/target/mips/tcg/msa_translate.c
> +++ b/target/mips/tcg/msa_translate.c
> @@ -752,8 +752,8 @@ static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a,
>   }
>   
>   TRANS(FCLASS,   trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_u_df);
>   TRANS(FSQRT,    trans_msa_2rf, gen_helper_msa_fsqrt_df);
>   TRANS(FRSQRT,   trans_msa_2rf, gen_helper_msa_frsqrt_df);
>   TRANS(FRCP,     trans_msa_2rf, gen_helper_msa_frcp_df);

Fixes: 5c5b64000c ("target/mips: Convert MSA 2RF instruction format to 
decodetree")

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Queued.

Re: [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper

Posted by Richard Henderson 1 year, 12 months ago

On 5/3/22 07:42, nihui wrote:
> Fix the FTRUNC_S and FTRUNC_U trans helper problem.
> 
> Signed-off-by: nihui <shuizhuyuanluo@126.com>
> ---
>   target/mips/tcg/msa_translate.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c
> index 0b3dd0957c..1bcdbb1121 100644
> --- a/target/mips/tcg/msa_translate.c
> +++ b/target/mips/tcg/msa_translate.c
> @@ -752,8 +752,8 @@ static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a,
>   }
>   
>   TRANS(FCLASS,   trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_u_df);
>   TRANS(FSQRT,    trans_msa_2rf, gen_helper_msa_fsqrt_df);
>   TRANS(FRSQRT,   trans_msa_2rf, gen_helper_msa_frsqrt_df);
>   TRANS(FRCP,     trans_msa_2rf, gen_helper_msa_frcp_df);

Cc: phil
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~