1 | The following changes since commit 9c125d17e9402c232c46610802e5931b3639d77b: | 1 | The following changes since commit 30aa19446d82358a30eac3b556b4d6641e00b7c1: |
---|---|---|---|
2 | 2 | ||
3 | Merge tag 'pull-tcg-20220420' of https://gitlab.com/rth7680/qemu into staging (2022-04-20 16:43:11 -0700) | 3 | Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200812' into staging (2020-08-24 16:39:53 +0100) |
4 | 4 | ||
5 | are available in the Git repository at: | 5 | are available in the Git repository at: |
6 | 6 | ||
7 | https://gitlab.com/stefanha/qemu.git tags/block-pull-request | 7 | https://github.com/XanClic/qemu.git tags/pull-block-2020-08-26 |
8 | 8 | ||
9 | for you to fetch changes up to d45c83328feab2e4083991693160f0a417cfd9b0: | 9 | for you to fetch changes up to a5d3cfa2dc775e5d99f013703b8508f1d989d588: |
10 | 10 | ||
11 | virtiofsd: Add docs/helper for killpriv_v2/no_killpriv_v2 option (2022-04-21 12:05:15 +0200) | 11 | iotests: Add tests for qcow2 images with extended L2 entries (2020-08-26 08:49:51 +0200) |
12 | 12 | ||
13 | ---------------------------------------------------------------- | 13 | ---------------------------------------------------------------- |
14 | Pull request | 14 | Block patches: |
15 | 15 | - qcow2 subclusters (extended L2 entries) | |
16 | Small contrib/vhost-user-blk, contrib/vhost-user-scsi, and tools/virtiofsd | ||
17 | improvements. | ||
18 | 16 | ||
19 | ---------------------------------------------------------------- | 17 | ---------------------------------------------------------------- |
18 | v2: | ||
19 | - Fixed the shebang line in iotest 271 | ||
20 | 20 | ||
21 | Liu Yiding (1): | 21 | ---------------------------------------------------------------- |
22 | virtiofsd: Add docs/helper for killpriv_v2/no_killpriv_v2 option | 22 | Alberto Garcia (34): |
23 | qcow2: Make Qcow2AioTask store the full host offset | ||
24 | qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset() | ||
25 | qcow2: Add calculate_l2_meta() | ||
26 | qcow2: Split cluster_needs_cow() out of count_cow_clusters() | ||
27 | qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied() | ||
28 | qcow2: Add get_l2_entry() and set_l2_entry() | ||
29 | qcow2: Document the Extended L2 Entries feature | ||
30 | qcow2: Add dummy has_subclusters() function | ||
31 | qcow2: Add subcluster-related fields to BDRVQcow2State | ||
32 | qcow2: Add offset_to_sc_index() | ||
33 | qcow2: Add offset_into_subcluster() and size_to_subclusters() | ||
34 | qcow2: Add l2_entry_size() | ||
35 | qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap() | ||
36 | qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type() | ||
37 | qcow2: Add qcow2_get_subcluster_range_type() | ||
38 | qcow2: Add qcow2_cluster_is_allocated() | ||
39 | qcow2: Add cluster type parameter to qcow2_get_host_offset() | ||
40 | qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_* | ||
41 | qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC | ||
42 | qcow2: Add subcluster support to calculate_l2_meta() | ||
43 | qcow2: Add subcluster support to qcow2_get_host_offset() | ||
44 | qcow2: Add subcluster support to zero_in_l2_slice() | ||
45 | qcow2: Add subcluster support to discard_in_l2_slice() | ||
46 | qcow2: Add subcluster support to check_refcounts_l2() | ||
47 | qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2() | ||
48 | qcow2: Clear the L2 bitmap when allocating a compressed cluster | ||
49 | qcow2: Add subcluster support to handle_alloc_space() | ||
50 | qcow2: Add subcluster support to qcow2_co_pwrite_zeroes() | ||
51 | qcow2: Add subcluster support to qcow2_measure() | ||
52 | qcow2: Add prealloc field to QCowL2Meta | ||
53 | qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit | ||
54 | qcow2: Allow preallocation and backing files if extended_l2 is set | ||
55 | qcow2: Assert that expand_zero_clusters_in_l1() does not support | ||
56 | subclusters | ||
57 | iotests: Add tests for qcow2 images with extended L2 entries | ||
23 | 58 | ||
24 | Sakshi Kaushik (1): | 59 | docs/interop/qcow2.txt | 68 ++- |
25 | Implements Backend Program conventions for vhost-user-scsi | 60 | docs/qcow2-cache.txt | 19 +- |
26 | 61 | qapi/block-core.json | 7 + | |
27 | Stefan Hajnoczi (1): | 62 | block/qcow2.h | 211 ++++++- |
28 | contrib/vhost-user-blk: add missing GOptionEntry NULL terminator | 63 | include/block/block_int.h | 1 + |
29 | 64 | block/qcow2-cluster.c | 906 +++++++++++++++++++++---------- | |
30 | docs/tools/virtiofsd.rst | 5 ++ | 65 | block/qcow2-refcount.c | 47 +- |
31 | contrib/vhost-user-blk/vhost-user-blk.c | 3 +- | 66 | block/qcow2.c | 302 +++++++---- |
32 | contrib/vhost-user-scsi/vhost-user-scsi.c | 77 +++++++++++++++-------- | 67 | block/trace-events | 2 +- |
33 | tools/virtiofsd/helper.c | 3 + | 68 | tests/qemu-iotests/031.out | 8 +- |
34 | 4 files changed, 62 insertions(+), 26 deletions(-) | 69 | tests/qemu-iotests/036.out | 4 +- |
70 | tests/qemu-iotests/049.out | 102 ++-- | ||
71 | tests/qemu-iotests/060.out | 3 +- | ||
72 | tests/qemu-iotests/061 | 6 + | ||
73 | tests/qemu-iotests/061.out | 25 +- | ||
74 | tests/qemu-iotests/065 | 12 +- | ||
75 | tests/qemu-iotests/082.out | 39 +- | ||
76 | tests/qemu-iotests/085.out | 38 +- | ||
77 | tests/qemu-iotests/144.out | 4 +- | ||
78 | tests/qemu-iotests/182.out | 2 +- | ||
79 | tests/qemu-iotests/185.out | 8 +- | ||
80 | tests/qemu-iotests/198 | 2 + | ||
81 | tests/qemu-iotests/206.out | 6 +- | ||
82 | tests/qemu-iotests/242.out | 5 + | ||
83 | tests/qemu-iotests/255.out | 8 +- | ||
84 | tests/qemu-iotests/271 | 901 ++++++++++++++++++++++++++++++ | ||
85 | tests/qemu-iotests/271.out | 726 +++++++++++++++++++++++++ | ||
86 | tests/qemu-iotests/274.out | 49 +- | ||
87 | tests/qemu-iotests/280.out | 2 +- | ||
88 | tests/qemu-iotests/291.out | 2 + | ||
89 | tests/qemu-iotests/302.out | 1 + | ||
90 | tests/qemu-iotests/303.out | 4 +- | ||
91 | tests/qemu-iotests/common.filter | 1 + | ||
92 | tests/qemu-iotests/group | 1 + | ||
93 | 34 files changed, 2952 insertions(+), 570 deletions(-) | ||
94 | create mode 100755 tests/qemu-iotests/271 | ||
95 | create mode 100644 tests/qemu-iotests/271.out | ||
35 | 96 | ||
36 | -- | 97 | -- |
37 | 2.35.1 | 98 | 2.26.2 |
99 | |||
100 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Sakshi Kaushik <sakshikaushik717@gmail.com> | ||
2 | 1 | ||
3 | Signed-off-by: Sakshi Kaushik <sakshikaushik717@gmail.com> | ||
4 | Message-id: 20220406162410.8536-1-sakshikaushik717@gmail.com | ||
5 | |||
6 | [Name the iSCSI URL long option --iscsi-uri instead of --iscsi_uri for | ||
7 | consistency, fix --fd which was rejected due to an outdated | ||
8 | --socket-path check, and add missing entries[] terminator. | ||
9 | --Stefan] | ||
10 | |||
11 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
12 | --- | ||
13 | contrib/vhost-user-scsi/vhost-user-scsi.c | 77 +++++++++++++++-------- | ||
14 | 1 file changed, 52 insertions(+), 25 deletions(-) | ||
15 | |||
16 | diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c | ||
17 | index XXXXXXX..XXXXXXX 100644 | ||
18 | --- a/contrib/vhost-user-scsi/vhost-user-scsi.c | ||
19 | +++ b/contrib/vhost-user-scsi/vhost-user-scsi.c | ||
20 | @@ -XXX,XX +XXX,XX @@ fail: | ||
21 | |||
22 | /** vhost-user-scsi **/ | ||
23 | |||
24 | +static int opt_fdnum = -1; | ||
25 | +static char *opt_socket_path; | ||
26 | +static gboolean opt_print_caps; | ||
27 | +static char *iscsi_uri; | ||
28 | + | ||
29 | +static GOptionEntry entries[] = { | ||
30 | + { "print-capabilities", 'c', 0, G_OPTION_ARG_NONE, &opt_print_caps, | ||
31 | + "Print capabilities", NULL }, | ||
32 | + { "fd", 'f', 0, G_OPTION_ARG_INT, &opt_fdnum, | ||
33 | + "Use inherited fd socket", "FDNUM" }, | ||
34 | + { "iscsi-uri", 'i', 0, G_OPTION_ARG_FILENAME, &iscsi_uri, | ||
35 | + "iSCSI URI to connect to", "FDNUM" }, | ||
36 | + { "socket-path", 's', 0, G_OPTION_ARG_FILENAME, &opt_socket_path, | ||
37 | + "Use UNIX socket path", "PATH" }, | ||
38 | + { NULL, } | ||
39 | +}; | ||
40 | + | ||
41 | int main(int argc, char **argv) | ||
42 | { | ||
43 | VusDev *vdev_scsi = NULL; | ||
44 | - char *unix_fn = NULL; | ||
45 | - char *iscsi_uri = NULL; | ||
46 | - int lsock = -1, csock = -1, opt, err = EXIT_SUCCESS; | ||
47 | + int lsock = -1, csock = -1, err = EXIT_SUCCESS; | ||
48 | |||
49 | - while ((opt = getopt(argc, argv, "u:i:")) != -1) { | ||
50 | - switch (opt) { | ||
51 | - case 'h': | ||
52 | - goto help; | ||
53 | - case 'u': | ||
54 | - unix_fn = g_strdup(optarg); | ||
55 | - break; | ||
56 | - case 'i': | ||
57 | - iscsi_uri = g_strdup(optarg); | ||
58 | - break; | ||
59 | - default: | ||
60 | - goto help; | ||
61 | - } | ||
62 | + GError *error = NULL; | ||
63 | + GOptionContext *context; | ||
64 | + | ||
65 | + context = g_option_context_new(NULL); | ||
66 | + g_option_context_add_main_entries(context, entries, NULL); | ||
67 | + if (!g_option_context_parse(context, &argc, &argv, &error)) { | ||
68 | + g_printerr("Option parsing failed: %s\n", error->message); | ||
69 | + exit(EXIT_FAILURE); | ||
70 | + } | ||
71 | + | ||
72 | + if (opt_print_caps) { | ||
73 | + g_print("{\n"); | ||
74 | + g_print(" \"type\": \"scsi\"\n"); | ||
75 | + g_print("}\n"); | ||
76 | + goto out; | ||
77 | } | ||
78 | - if (!unix_fn || !iscsi_uri) { | ||
79 | + | ||
80 | + if (!iscsi_uri) { | ||
81 | goto help; | ||
82 | } | ||
83 | |||
84 | - lsock = unix_sock_new(unix_fn); | ||
85 | - if (lsock < 0) { | ||
86 | - goto err; | ||
87 | + if (opt_socket_path) { | ||
88 | + lsock = unix_sock_new(opt_socket_path); | ||
89 | + if (lsock < 0) { | ||
90 | + exit(EXIT_FAILURE); | ||
91 | + } | ||
92 | + } else if (opt_fdnum < 0) { | ||
93 | + g_print("%s\n", g_option_context_get_help(context, true, NULL)); | ||
94 | + exit(EXIT_FAILURE); | ||
95 | + } else { | ||
96 | + lsock = opt_fdnum; | ||
97 | } | ||
98 | |||
99 | csock = accept(lsock, NULL, NULL); | ||
100 | @@ -XXX,XX +XXX,XX @@ out: | ||
101 | if (vdev_scsi) { | ||
102 | g_main_loop_unref(vdev_scsi->loop); | ||
103 | g_free(vdev_scsi); | ||
104 | - unlink(unix_fn); | ||
105 | + unlink(opt_socket_path); | ||
106 | } | ||
107 | if (csock >= 0) { | ||
108 | close(csock); | ||
109 | @@ -XXX,XX +XXX,XX @@ out: | ||
110 | if (lsock >= 0) { | ||
111 | close(lsock); | ||
112 | } | ||
113 | - g_free(unix_fn); | ||
114 | + g_free(opt_socket_path); | ||
115 | g_free(iscsi_uri); | ||
116 | |||
117 | return err; | ||
118 | @@ -XXX,XX +XXX,XX @@ err: | ||
119 | goto out; | ||
120 | |||
121 | help: | ||
122 | - fprintf(stderr, "Usage: %s [ -u unix_sock_path -i iscsi_uri ] | [ -h ]\n", | ||
123 | + fprintf(stderr, "Usage: %s [ -s socket-path -i iscsi-uri -f fd -p print-capabilities ] | [ -h ]\n", | ||
124 | argv[0]); | ||
125 | - fprintf(stderr, " -u path to unix socket\n"); | ||
126 | - fprintf(stderr, " -i iscsi uri for lun 0\n"); | ||
127 | + fprintf(stderr, " -s, --socket-path=SOCKET_PATH path to unix socket\n"); | ||
128 | + fprintf(stderr, " -i, --iscsi-uri=ISCSI_URI iscsi uri for lun 0\n"); | ||
129 | + fprintf(stderr, " -f, --fd=FILE_DESCRIPTOR file-descriptor\n"); | ||
130 | + fprintf(stderr, " -p, --print-capabilities=PRINT_CAPABILITIES denotes print-capabilities\n"); | ||
131 | fprintf(stderr, " -h print help and quit\n"); | ||
132 | |||
133 | goto err; | ||
134 | -- | ||
135 | 2.35.1 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | The GLib documentation says "a NULL-terminated array of GOptionEntrys" | ||
2 | so we'd better make sure there is a terminator that lets | ||
3 | g_option_context_add_main_entries() know when the end of the array has | ||
4 | been reached. | ||
5 | 1 | ||
6 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
7 | Reviewed-by: Michael S. Tsirkin <mst@redhat.com> | ||
8 | Message-id: 20220411150057.3009667-1-stefanha@redhat.com | ||
9 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
10 | --- | ||
11 | contrib/vhost-user-blk/vhost-user-blk.c | 3 ++- | ||
12 | 1 file changed, 2 insertions(+), 1 deletion(-) | ||
13 | |||
14 | diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/contrib/vhost-user-blk/vhost-user-blk.c | ||
17 | +++ b/contrib/vhost-user-blk/vhost-user-blk.c | ||
18 | @@ -XXX,XX +XXX,XX @@ static GOptionEntry entries[] = { | ||
19 | {"blk-file", 'b', 0, G_OPTION_ARG_FILENAME, &opt_blk_file, | ||
20 | "block device or file path", "PATH"}, | ||
21 | { "read-only", 'r', 0, G_OPTION_ARG_NONE, &opt_read_only, | ||
22 | - "Enable read-only", NULL } | ||
23 | + "Enable read-only", NULL }, | ||
24 | + { NULL, }, | ||
25 | }; | ||
26 | |||
27 | int main(int argc, char **argv) | ||
28 | -- | ||
29 | 2.35.1 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Liu Yiding <liuyd.fnst@fujitsu.com> | ||
2 | 1 | ||
3 | virtiofsd has introduced killpriv_v2/no_killpriv_v2 for a while. Add | ||
4 | description of it to docs/helper. | ||
5 | |||
6 | Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> | ||
7 | Message-Id: <20220421095151.2231099-1-liuyd.fnst@fujitsu.com> | ||
8 | |||
9 | [Small documentation fixes: s/as client supports/as the client supports/ | ||
10 | and s/. /. /. | ||
11 | --Stefan] | ||
12 | |||
13 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
14 | --- | ||
15 | docs/tools/virtiofsd.rst | 5 +++++ | ||
16 | tools/virtiofsd/helper.c | 3 +++ | ||
17 | 2 files changed, 8 insertions(+) | ||
18 | |||
19 | diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst | ||
20 | index XXXXXXX..XXXXXXX 100644 | ||
21 | --- a/docs/tools/virtiofsd.rst | ||
22 | +++ b/docs/tools/virtiofsd.rst | ||
23 | @@ -XXX,XX +XXX,XX @@ Options | ||
24 | label. Server will try to set that label on newly created file | ||
25 | atomically wherever possible. | ||
26 | |||
27 | + * killpriv_v2|no_killpriv_v2 - | ||
28 | + Enable/disable ``FUSE_HANDLE_KILLPRIV_V2`` support. KILLPRIV_V2 is enabled | ||
29 | + by default as long as the client supports it. Enabling this option helps | ||
30 | + with performance in write path. | ||
31 | + | ||
32 | .. option:: --socket-path=PATH | ||
33 | |||
34 | Listen on vhost-user UNIX domain socket at PATH. | ||
35 | diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c | ||
36 | index XXXXXXX..XXXXXXX 100644 | ||
37 | --- a/tools/virtiofsd/helper.c | ||
38 | +++ b/tools/virtiofsd/helper.c | ||
39 | @@ -XXX,XX +XXX,XX @@ void fuse_cmdline_help(void) | ||
40 | " -o announce_submounts Announce sub-mount points to the guest\n" | ||
41 | " -o posix_acl/no_posix_acl Enable/Disable posix_acl. (default: disabled)\n" | ||
42 | " -o security_label/no_security_label Enable/Disable security label. (default: disabled)\n" | ||
43 | + " -o killpriv_v2/no_killpriv_v2\n" | ||
44 | + " Enable/Disable FUSE_HANDLE_KILLPRIV_V2.\n" | ||
45 | + " (default: enabled as long as client supports it)\n" | ||
46 | ); | ||
47 | } | ||
48 | |||
49 | -- | ||
50 | 2.35.1 | diff view generated by jsdifflib |