[PATCH v2 11/11] q800: add default vendor and product information for scsi-cd devices

Mark Cave-Ayland posted 11 patches 3 years, 9 months ago
Maintainers: Laurent Vivier <laurent@vivier.eu>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>
There is a newer version of this series
[PATCH v2 11/11] q800: add default vendor and product information for scsi-cd devices
Posted by Mark Cave-Ayland 3 years, 9 months ago
The MacOS CDROM driver uses a SCSI INQUIRY command to check that any SCSI CDROMs
detected match a whitelist of vendors and products before adding them to the
list of available devices.

Add known-good default vendor and product information using the existing
compat_prop mechanism so the user doesn't have to use long command lines to set
the qdev properties manually.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/m68k/q800.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
index abb549f8d8..8b34776c8e 100644
--- a/hw/m68k/q800.c
+++ b/hw/m68k/q800.c
@@ -692,6 +692,9 @@ static GlobalProperty hw_compat_q800[] = {
     { "scsi-hd", "product", "          ST225N" },
     { "scsi-hd", "ver", "1.0 " },
     { "scsi-cd", "quirk_mode_sense_rom_force_dbd", "on"},
+    { "scsi-cd", "vendor", "MATSHITA" },
+    { "scsi-cd", "product", "CD-ROM CR-8005" },
+    { "scsi-cd", "ver", "1.0k" },
 };
 static const size_t hw_compat_q800_len = G_N_ELEMENTS(hw_compat_q800);
 
-- 
2.20.1
Re: [PATCH v2 11/11] q800: add default vendor and product information for scsi-cd devices
Posted by Laurent Vivier 3 years, 8 months ago
Le 24/04/2022 à 18:49, Mark Cave-Ayland a écrit :
> The MacOS CDROM driver uses a SCSI INQUIRY command to check that any SCSI CDROMs
> detected match a whitelist of vendors and products before adding them to the
> list of available devices.
> 
> Add known-good default vendor and product information using the existing
> compat_prop mechanism so the user doesn't have to use long command lines to set
> the qdev properties manually.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   hw/m68k/q800.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
> index abb549f8d8..8b34776c8e 100644
> --- a/hw/m68k/q800.c
> +++ b/hw/m68k/q800.c
> @@ -692,6 +692,9 @@ static GlobalProperty hw_compat_q800[] = {
>       { "scsi-hd", "product", "          ST225N" },
>       { "scsi-hd", "ver", "1.0 " },
>       { "scsi-cd", "quirk_mode_sense_rom_force_dbd", "on"},
> +    { "scsi-cd", "vendor", "MATSHITA" },
> +    { "scsi-cd", "product", "CD-ROM CR-8005" },
> +    { "scsi-cd", "ver", "1.0k" },
>   };
>   static const size_t hw_compat_q800_len = G_N_ELEMENTS(hw_compat_q800);
>   

Reviewed-by: Laurent Vivier <laurent@vivier.eu>