testing, docs and gdbstub pre-PR

[PATCH v1 21/25] tests/tcg: remove duplicate sha512-sse case

Posted by Alex Bennée 3 years, 9 months ago

We already generate the sha512-sse case in the i386 makefile which
works for both i386 and x86_64.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Fixes: f8a4c6d728 ("tests/tcg: add vectorised sha512 versions")
---
 tests/tcg/x86_64/Makefile.target | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/tcg/x86_64/Makefile.target b/tests/tcg/x86_64/Makefile.target
index f9fcd31caf..b71a6bcd5e 100644
--- a/tests/tcg/x86_64/Makefile.target
+++ b/tests/tcg/x86_64/Makefile.target
@@ -22,10 +22,3 @@ test-x86_64: test-i386.c test-i386.h test-i386-shift.h test-i386-muldiv.h
 
 vsyscall: $(SRC_PATH)/tests/tcg/x86_64/vsyscall.c
 	$(CC) $(CFLAGS) $< -o $@ $(LDFLAGS)
-
-# TCG does not yet support all SSE (SIGILL on pshufb)
-# sha512-sse: CFLAGS=-march=core2 -O3
-# sha512-sse: sha512.c
-# 	$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
-
-TESTS+=sha512-sse
-- 
2.30.2

Re: [PATCH v1 21/25] tests/tcg: remove duplicate sha512-sse case

Posted by Richard Henderson 3 years, 9 months ago

On 4/19/22 02:10, Alex Bennée wrote:
> We already generate the sha512-sse case in the i386 makefile which
> works for both i386 and x86_64.
> 
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Fixes: f8a4c6d728 ("tests/tcg: add vectorised sha512 versions")
> ---
>   tests/tcg/x86_64/Makefile.target | 7 -------
>   1 file changed, 7 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~